Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17823: [C++] Revert std::make_shared change for CUDA #14233

Merged
merged 1 commit into from
Sep 26, 2022
Merged

ARROW-17823: [C++] Revert std::make_shared change for CUDA #14233

merged 1 commit into from
Sep 26, 2022

Conversation

kou
Copy link
Member

@kou kou commented Sep 25, 2022

This is a follow-up of #14216. We can't use std::make_shared for CUDA related classes because their constructors aren't public.

@kou
ARROW-17823: [C++] Revert std::make_shared change for CUDA
13856fc 
This is a follow-up of apache#14216. We can't use std::make_shared for CUDA
related classes because their constructors aren't public.
@kou
Copy link
Member Author

kou commented Sep 25, 2022

@github-actions crossbow submit debian-bookworm-amd64

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17823

@github-actions
Copy link

Revision: 13856fc

Submitted crossbow builds: ursacomputing/crossbow @ actions-00cfe95e4e

Task Status
debian-bookworm-amd64 Github Actions

@kou
Copy link
Member Author

kou commented Sep 26, 2022

+1

@kou kou merged commit b76ddf1 into apache:master Sep 26, 2022
@kou kou deleted the cpp-make-shared-cuda branch September 26, 2022 01:39
@ursabot
Copy link

ursabot commented Sep 26, 2022

Benchmark runs are scheduled for baseline = 7808280 and contender = b76ddf1. b76ddf1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.48% ⬆️0.1%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.5% ⬆️0.18%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] b76ddf19 ec2-t3-xlarge-us-east-2
[Failed] b76ddf19 test-mac-arm
[Failed] b76ddf19 ursa-i9-9960x
[Finished] b76ddf19 ursa-thinkcentre-m75q
[Finished] 78082800 ec2-t3-xlarge-us-east-2
[Failed] 78082800 test-mac-arm
[Failed] 78082800 ursa-i9-9960x
[Finished] 78082800 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@kou @zagto
ARROW-17823: [C++] Revert std::make_shared change for CUDA (apache#14233
a0bae16 
)

This is a follow-up of apache#14216. We can't use std::make_shared for CUDA related classes because their constructors aren't public.

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@kou @fatemehp
ARROW-17823: [C++] Revert std::make_shared change for CUDA (apache#14233
4d2f980 
)

This is a follow-up of apache#14216. We can't use std::make_shared for CUDA related classes because their constructors aren't public.

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kou @ursabot