Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-14885: [Docs] Make changes to the New Contrib Guide (Jira -> GitHub) #14889

Merged
merged 4 commits into from
Dec 22, 2022
Merged

GH-14885: [Docs] Make changes to the New Contrib Guide (Jira -> GitHub) #14889

merged 4 commits into from
Dec 22, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Dec 8, 2022 •
edited by github-actions bot
Loading

This PR is part of the work to update the documentation as we are moving from Jira issue tracker to GitHub issues:
#14822

Closes #14885

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

⚠️ GitHub issue #14885 has no components, please add labels for components.

@AlenkaF AlenkaF marked this pull request as ready for review December 12, 2022 07:43
@pitrou
Copy link
Member

pitrou commented Dec 12, 2022

Hmm... can you give this a different title and description than #14919? I find this a bit confusing :-)

@AlenkaF
Copy link
Member Author

AlenkaF commented Dec 13, 2022

Hmm... can you give this a different title and description than #14919? I find this a bit confusing :-)

Oh 🤦‍♀️ Forgot to change the title of the PR :-)

@AlenkaF AlenkaF changed the title GH-14885: [Docs] Make changes to developers section of the docs (Jira -> GitHub) GH-14885: [Docs] Make changes to the New Contrib Guide (Jira -> GitHub) Dec 13, 2022
jorisvandenbossche
jorisvandenbossche reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating those guides! Looking good, added a few tiny comments

docs/source/developers/guide/documentation.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/finding_issues.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/finding_issues.rst Outdated Show resolved Hide resolved
docs/source/developers/guide/step_by_step/finding_issues.rst Outdated Show resolved Hide resolved
@AlenkaF @jorisvandenbossche
Apply suggestions from code review - Joris
c1c4b56 
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@AlenkaF @raulcd
Update docs/source/developers/guide/index.rst
2896ff1 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@jorisvandenbossche jorisvandenbossche merged commit 3b26565 into apache:master Dec 22, 2022
@jorisvandenbossche
Copy link
Member

Thanks!

@jorisvandenbossche jorisvandenbossche added this to the 11.0.0 milestone Dec 22, 2022
@AlenkaF AlenkaF deleted the dev-docs-update branch December 22, 2022 10:48
@ursabot
Copy link

ursabot commented Dec 22, 2022

Benchmark runs are scheduled for baseline = 98d7ff0 and contender = 3b26565. 3b26565 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.03% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3b265658 ec2-t3-xlarge-us-east-2
[Failed] 3b265658 test-mac-arm
[Finished] 3b265658 ursa-i9-9960x
[Finished] 3b265658 ursa-thinkcentre-m75q
[Finished] 98d7ff0c ec2-t3-xlarge-us-east-2
[Failed] 98d7ff0c test-mac-arm
[Finished] 98d7ff0c ursa-i9-9960x
[Finished] 98d7ff0c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Dec 22, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
@AlenkaF @jorisvandenbossche
@raulcd @EpsilonPrime
apacheGH-14885: [Docs] Make changes to the New Contrib Guide (Jira ->…
685a8fe 
… GitHub) (apache#14889)

This PR is part of the work to update the documentation as we are moving from Jira issue tracker to GitHub issues:
apache#14822

Closes apache#14885
* Closes: apache#14885

Lead-authored-by: Alenka Frim <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd left review comments

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Component: Documentation
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

[Docs] Make changes to the New Contrib Guide (Jira -> GitHub)
5 participants
@AlenkaF @pitrou @jorisvandenbossche @ursabot @raulcd