Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15110: [R] [CI] Windows build fails in packaging job #15111

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

jonkeane
Copy link
Member

@jonkeane jonkeane commented Dec 29, 2022

Add new dependencies to windows builds following #14235

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #15110 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

⚠️ GitHub issue #15110 has no components, please add labels for components.

@jonkeane jonkeane force-pushed the 15110-windows-build branch from 5238af9 to 3842257 Compare December 29, 2022 15:24
@jonkeane
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: 3842257

Submitted crossbow builds: ursacomputing/crossbow @ actions-28f0c8d781

Task Status
r-binary-packages Github Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: 97e9181

Submitted crossbow builds: ursacomputing/crossbow @ actions-1ae469e3c6

Task Status
r-binary-packages Github Actions

@assignUser
Copy link
Member

This seems to be the correct fix for the issue but I don't think #14235 or the follow up #15075 are the cause (even if they would be my first guess too) as the R win 4.2 checks were green as recent as a0d1630 and only started failing with aac3087 (on merge, within the PR the check was green...) the rtools version used is unchanged and so is the runner image, so I am unsure what could have caused the change?

I'll test this for HEAD and this PR locally.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah wow, just saw your investigation in #15110 @jonkeane I agree it likely is the updated curl version, I had a look at the changelog and there were changes related to nghttp2 but nothing I could immediatly identify as cause of the issue. It still makes sense as the cause!

@assignUser assignUser merged commit 7317ff1 into apache:master Dec 29, 2022
@jonkeane
Copy link
Member Author

Ah yes, sorry I should have updated the description here with that info too. Agreed that that PR is likely not the root cause, but something upstream in mingw dependency land

@ursabot
Copy link

ursabot commented Dec 29, 2022

Benchmark runs are scheduled for baseline = 463cdcc and contender = 7317ff1. 7317ff1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️1.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.69% ⬆️0.21%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7317ff10 ec2-t3-xlarge-us-east-2
[Failed] 7317ff10 test-mac-arm
[Finished] 7317ff10 ursa-i9-9960x
[Finished] 7317ff10 ursa-thinkcentre-m75q
[Finished] 463cdccd ec2-t3-xlarge-us-east-2
[Failed] 463cdccd test-mac-arm
[Finished] 463cdccd ursa-i9-9960x
[Finished] 463cdccd ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Dec 29, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
…#15111)

Add new dependencies to windows builds following apache#14235
* Closes: apache#15110

Authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] [CI] Windows build fails in packaging job
4 participants