-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-15110: [R] [CI] Windows build fails in packaging job #15111
Conversation
|
|
5238af9
to
3842257
Compare
@github-actions crossbow submit r-binary-packages |
Revision: 3842257 Submitted crossbow builds: ursacomputing/crossbow @ actions-28f0c8d781
|
@github-actions crossbow submit r-binary-packages |
Revision: 97e9181 Submitted crossbow builds: ursacomputing/crossbow @ actions-1ae469e3c6
|
This seems to be the correct fix for the issue but I don't think #14235 or the follow up #15075 are the cause (even if they would be my first guess too) as the R win 4.2 checks were green as recent as a0d1630 and only started failing with aac3087 (on merge, within the PR the check was green...) the rtools version used is unchanged and so is the runner image, so I am unsure what could have caused the change? I'll test this for HEAD and this PR locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, sorry I should have updated the description here with that info too. Agreed that that PR is likely not the root cause, but something upstream in mingw dependency land |
Benchmark runs are scheduled for baseline = 463cdcc and contender = 7317ff1. 7317ff1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
…#15111) Add new dependencies to windows builds following apache#14235 * Closes: apache#15110 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Add new dependencies to windows builds following #14235