-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-15185: [C++][Parquet] Improve documentation for Parquet Reader column_indices #15184
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of old issues on JIRA the title also supports:
See also: |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: I think this doc comment is misleading as well:
arrow/cpp/src/parquet/metadata.h
Line 285 in 2410d36
/// \brief The number of top-level columns in the schema. |
It returns the number of leaf fields in the schema, not the number of top-level ones (at least as most people would understand). Would you mind updating that as well?
Improvement in comments Co-authored-by: Will Jones <willjones127@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks @LouisClt!
Benchmark runs are scheduled for baseline = 6bd847b and contender = a580f27. a580f27 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
…er column_indices (apache#15184) This aims to fix the documentation and improve it,, by better specifying to what level the column_indices given in argument refer to. * Closes: apache#15185 Lead-authored-by: LouisClt <louis1110@hotmail.fr> Co-authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
…er column_indices (apache#15184) This aims to fix the documentation and improve it,, by better specifying to what level the column_indices given in argument refer to. * Closes: apache#15185 Lead-authored-by: LouisClt <louis1110@hotmail.fr> Co-authored-by: Will Jones <willjones127@gmail.com> Signed-off-by: Will Jones <willjones127@gmail.com>
This aims to fix the documentation and improve it,, by better specifying to what level the column_indices given in argument refer to.