Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15257: [GLib][Dataset] Add GADatasetHivePartitioning #15272

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jan 9, 2023

This has some breaking changes:

  • GADatasetPartitioningOptions -> GADatasetPartitioningFactoryOptions
  • gadataset_directory_partitioning_new() uses GADatasetKeyValuePartitioningOptions instead of GADatasetPartitioningOptions
  • gadataset_partitioning_new() -> gadataset_default_partitioning_new()
  • Closes: [GLib][Dataset] Add GADatasetHivePartitioning #15257

This has some breaking changes:

* `GADatasetPartitioningOptions` ->
  `GADatasetPartitioningFactoryOptions`
* `gadataset_directory_partitioning_new()` uses
  `GADatasetKeyValuePartitioningOptions` instead of
  `GADatasetPartitioningOptions`
* `gadataset_partitioning_new()` ->
  `gadataset_default_partitioning_new()`
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

⚠️ GitHub issue #15257 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Jan 11, 2023

+1

@kou kou merged commit 943580e into apache:master Jan 11, 2023
@kou kou deleted the glib-dataset-hive-partitioning branch January 11, 2023 03:04
@ursabot
Copy link

ursabot commented Jan 11, 2023

Benchmark runs are scheduled for baseline = d10bc18 and contender = 943580e. 943580e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.87% ⬆️0.12%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.72% ⬆️0.12%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 943580e2 ec2-t3-xlarge-us-east-2
[Finished] 943580e2 test-mac-arm
[Finished] 943580e2 ursa-i9-9960x
[Finished] 943580e2 ursa-thinkcentre-m75q
[Finished] d10bc18b ec2-t3-xlarge-us-east-2
[Finished] d10bc18b test-mac-arm
[Finished] d10bc18b ursa-i9-9960x
[Finished] d10bc18b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GLib][Dataset] Add GADatasetHivePartitioning
2 participants