-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-2226, ARROW-2233: [JS] Dictionary bugfixes #1671
Conversation
How does this bug present itself? I thought maybe |
Would definitely be good to have a unit test for this |
@wesm @TheNeuralBit yeah, I wanted to get a fix in first. I encountered this trying to read values from a DictionaryVector whose indices have a |
@wesm I might've asked this before, but is it possible (via the spec) for the |
The indices are supposed to be a signed integer type |
I already started adding some basic unit tests for DictionaryVector, so I'll look at adding a test that covers the indices |
Put up a PR with some tests: trxcllnt#5 |
Add dictionary vector unit tests
@TheNeuralBit you should be able to push directly to this branch, too, if that's easier |
Oh nice, I'll do that in the future, thanks @wesm |
@TheNeuralBit lgtm thanks! 👍 |
Resolves https://issues.apache.org/jira/browse/ARROW-2226