Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++] Remove unnecessary code in MultipathLevelBuilder::Write #33647

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

js8544
Copy link
Collaborator

@js8544 js8544 commented Jan 13, 2023

The PathBuilder run is unnecessary as MultipathLevelBuilder::Make on line 896 does the visitation already.

@vibhatha
Copy link
Collaborator

The CI failure is resolved in #33651

@pitrou
Copy link
Member

pitrou commented Jan 16, 2023

@js8544 Can you rebase or merge from master to get CI fixes?

@js8544 js8544 force-pushed the jinshang/multipath_level_builder branch from 6bd5c64 to 8a926b7 Compare January 16, 2023 14:49
@js8544 js8544 force-pushed the jinshang/multipath_level_builder branch from 8a926b7 to 0ba269c Compare January 17, 2023 01:51
@js8544 js8544 requested a review from wjones127 as a code owner January 17, 2023 01:51
@js8544
Copy link
Collaborator Author

js8544 commented Jan 17, 2023

@js8544 Can you rebase or merge from master to get CI fixes?

Yep. It's green now.

@pitrou pitrou changed the title MINOR: Remove unnecessary code in MultipathLevelBuilder::Write MINOR: [C++] Remove unnecessary code in MultipathLevelBuilder::Write Jan 17, 2023
@pitrou pitrou merged commit c525b57 into apache:master Jan 17, 2023
@ursabot
Copy link

ursabot commented Jan 18, 2023

Benchmark runs are scheduled for baseline = 1a82720 and contender = c525b57. c525b57 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.39% ⬆️0.12%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.37% ⬆️0.34%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c525b572 ec2-t3-xlarge-us-east-2
[Failed] c525b572 test-mac-arm
[Finished] c525b572 ursa-i9-9960x
[Finished] c525b572 ursa-thinkcentre-m75q
[Finished] 1a827200 ec2-t3-xlarge-us-east-2
[Failed] 1a827200 test-mac-arm
[Finished] 1a827200 ursa-i9-9960x
[Finished] 1a827200 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 18, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants