Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33705: [R] Fix link on README #33706

Merged
merged 3 commits into from
Jan 16, 2023
Merged

GH-33705: [R] Fix link on README #33706

merged 3 commits into from
Jan 16, 2023

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Jan 16, 2023 •
edited by github-actions bot
Loading

Fixes a link and removes a reference to "feather" that was sitting front and centre.

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #33705 has been automatically assigned in GitHub to PR creator.

@paleolimbot paleolimbot requested a review from thisisnic January 16, 2023 15:22
@paleolimbot paleolimbot mentioned this pull request Jan 16, 2023
Closed
42 tasks
@thisisnic
Copy link
Member

thisisnic commented Jan 16, 2023 •
edited
Loading

This one's a false alarm; it's not that this is really a broken link but it's just that it exists on the dev docs but not the live docs yet. Is the docs site always updated ahead of the CRAN release submission?

@paleolimbot
Copy link
Member Author

I see...let's leave it and only fix it right before submission (where the other urlchecker::url_check() bullet is in the checklist).

thisisnic
thisisnic reviewed Jan 16, 2023
View reviewed changes
r/README.md Outdated Show resolved Hide resolved
thisisnic
thisisnic approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note about "Feather" -> "Arrow" phrasing, feel free to take it or leave it

@paleolimbot @thisisnic
Update r/README.md
11f47ba 
Co-authored-by: Nic Crane <thisisnic@gmail.com>
@paleolimbot paleolimbot merged commit 7492cbe into apache:master Jan 16, 2023
@paleolimbot paleolimbot deleted the r-fix-links branch January 16, 2023 17:42
@ursabot
Copy link

ursabot commented Jan 17, 2023

Benchmark runs are scheduled for baseline = fcecfc1 and contender = 7492cbe. 7492cbe is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.33% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.15% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7492cbea ec2-t3-xlarge-us-east-2
[Failed] 7492cbea test-mac-arm
[Finished] 7492cbea ursa-i9-9960x
[Finished] 7492cbea ursa-thinkcentre-m75q
[Finished] fcecfc1e ec2-t3-xlarge-us-east-2
[Finished] fcecfc1e test-mac-arm
[Finished] fcecfc1e ursa-i9-9960x
[Finished] fcecfc1e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

raulcd pushed a commit that referenced this pull request Jan 18, 2023
@paleolimbot @thisisnic @raulcd
GH-33705: [R] Fix link on README (#33706)
3a2f365 
Fixes a link and removes a reference to "feather" that was sitting front and centre.
* Closes: #33705

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@voltrondata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnic thisisnic thisisnic approved these changes

Assignees
No one assigned
Labels
Component: Documentation Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R] Link on README is broken
3 participants
@paleolimbot @thisisnic @ursabot