Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++] Make the utilities used to implement run_end_encode available to other compute kernels #35002

Merged
merged 6 commits into from
Apr 13, 2023

Conversation

felipecrv
Copy link
Contributor

Rationale for this change

Make it easier to implement correct kernels dealing with run-end encoded data.

What changes are included in this PR?

Extraction of code to a header so kernels like REE filter kernels (see #35001) can use them.

Are these changes tested?

Indirectly via the run_end_encode and run_end_decode tests.

Are there any user-facing changes?

No, these are internal compute headers.

@felipecrv
Copy link
Contributor Author

@zeroshade @benibus

@felipecrv felipecrv marked this pull request as ready for review April 12, 2023 17:51
@felipecrv felipecrv requested a review from westonpace as a code owner April 12, 2023 17:51
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 12, 2023
Copy link
Collaborator

@benibus benibus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me! Just one comment.

cpp/src/arrow/CMakeLists.txt Show resolved Hide resolved
@zeroshade zeroshade merged commit ff94702 into apache:main Apr 13, 2023
@felipecrv felipecrv deleted the ree_compute_util branch April 13, 2023 18:46
@ursabot
Copy link

ursabot commented Apr 16, 2023

Benchmark runs are scheduled for baseline = 913c345 and contender = ff94702. ff94702 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️1.53% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.52% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ff94702e ec2-t3-xlarge-us-east-2
[Failed] ff94702e test-mac-arm
[Finished] ff94702e ursa-i9-9960x
[Finished] ff94702e ursa-thinkcentre-m75q
[Finished] 913c3450 ec2-t3-xlarge-us-east-2
[Failed] 913c3450 test-mac-arm
[Finished] 913c3450 ursa-i9-9960x
[Failed] 913c3450 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 16, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
…lable to other compute kernels (apache#35002)

### Rationale for this change

Make it easier to implement correct kernels dealing with run-end encoded data.

### What changes are included in this PR?

Extraction of code to a header so kernels like REE filter kernels (see apache#35001) can use them.

### Are these changes tested?

Indirectly via the `run_end_encode` and `run_end_decode` tests.

### Are there any user-facing changes?

No, these are internal compute headers.

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
…lable to other compute kernels (apache#35002)

### Rationale for this change

Make it easier to implement correct kernels dealing with run-end encoded data.

### What changes are included in this PR?

Extraction of code to a header so kernels like REE filter kernels (see apache#35001) can use them.

### Are these changes tested?

Indirectly via the `run_end_encode` and `run_end_decode` tests.

### Are there any user-facing changes?

No, these are internal compute headers.

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
…lable to other compute kernels (apache#35002)

### Rationale for this change

Make it easier to implement correct kernels dealing with run-end encoded data.

### What changes are included in this PR?

Extraction of code to a header so kernels like REE filter kernels (see apache#35001) can use them.

### Are these changes tested?

Indirectly via the `run_end_encode` and `run_end_decode` tests.

### Are there any user-facing changes?

No, these are internal compute headers.

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants