-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [C++] Make the utilities used to implement run_end_encode available to other compute kernels #35002
Conversation
6cf6c26
to
c3db551
Compare
…e_util_internal.cc/h
…ove it out of header This helps reduce binary bloat as well.
c3db551
to
3a3d1cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward to me! Just one comment.
Benchmark runs are scheduled for baseline = 913c345 and contender = ff94702. ff94702 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
…lable to other compute kernels (apache#35002) ### Rationale for this change Make it easier to implement correct kernels dealing with run-end encoded data. ### What changes are included in this PR? Extraction of code to a header so kernels like REE filter kernels (see apache#35001) can use them. ### Are these changes tested? Indirectly via the `run_end_encode` and `run_end_decode` tests. ### Are there any user-facing changes? No, these are internal compute headers. Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…lable to other compute kernels (apache#35002) ### Rationale for this change Make it easier to implement correct kernels dealing with run-end encoded data. ### What changes are included in this PR? Extraction of code to a header so kernels like REE filter kernels (see apache#35001) can use them. ### Are these changes tested? Indirectly via the `run_end_encode` and `run_end_decode` tests. ### Are there any user-facing changes? No, these are internal compute headers. Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…lable to other compute kernels (apache#35002) ### Rationale for this change Make it easier to implement correct kernels dealing with run-end encoded data. ### What changes are included in this PR? Extraction of code to a header so kernels like REE filter kernels (see apache#35001) can use them. ### Are these changes tested? Indirectly via the `run_end_encode` and `run_end_decode` tests. ### Are there any user-facing changes? No, these are internal compute headers. Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Rationale for this change
Make it easier to implement correct kernels dealing with run-end encoded data.
What changes are included in this PR?
Extraction of code to a header so kernels like REE filter kernels (see #35001) can use them.
Are these changes tested?
Indirectly via the
run_end_encode
andrun_end_decode
tests.Are there any user-facing changes?
No, these are internal compute headers.