GH-37453: [C++][Parquet] Performance fix for WriteBatch #37454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute the value for pages_change_on_record_boundaries on construction rather than on each call, as this adds a lot of overhead.
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
mapleFU
approved these changes
Aug 30, 2023
github-actions
bot
added
awaiting committer review
pitrou
approved these changes
Aug 30, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit f40bf77. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…#37454) ### Rationale for this change Reduces the time taken for `TypedColumnWriter::WriteBatch`, which regressed with apache#35230 ### What changes are included in this PR? This change computes the value for `pages_change_on_record_boundaries` once when a `TypedColumnWriter` is constructed rather than on every call to `WriteBatch`. ### Are these changes tested? This doesn't change behaviour so should be covered by existing tests. ### Are there any user-facing changes? No * Closes: apache#37453 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…#37454) ### Rationale for this change Reduces the time taken for `TypedColumnWriter::WriteBatch`, which regressed with apache#35230 ### What changes are included in this PR? This change computes the value for `pages_change_on_record_boundaries` once when a `TypedColumnWriter` is constructed rather than on every call to `WriteBatch`. ### Are these changes tested? This doesn't change behaviour so should be covered by existing tests. ### Are there any user-facing changes? No * Closes: apache#37453 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Reduces the time taken for
TypedColumnWriter::WriteBatch, which regressed with #35230What changes are included in this PR?
This change computes the value for
pages_change_on_record_boundariesonce when aTypedColumnWriteris constructed rather than on every call toWriteBatch.Are these changes tested?
This doesn't change behaviour so should be covered by existing tests.
Are there any user-facing changes?
No