-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37876: [Format] Add list-view specification to arrow format #37877
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
907987c
Format: Point out that there might be multiple physical layouts for e…
felipecrv e1426cf
Format: Use singular like all the other items in this list
felipecrv bc4d8a4
Format: Fix typos and remove trailing whitespace
felipecrv f070ce6
Format: Introduce the ListView layout to the spec
felipecrv f384285
Format: Add ListView and LargeListView to Flatbuffers spec
felipecrv 077684a
format/Schema.fbs: fix typo
felipecrv d88e00a
Improve the text after bkietz suggestions
felipecrv ddb1902
Columnar.rst: will -> it may because there are multiple possible repr…
felipecrv 42b8ec7
Columnar.rst: Be more strict about offset values
felipecrv 4cf8201
Columnar.rst: Fix title level for 'Variadic Buffers'
felipecrv 0d02bdc
Columnar.rst: Reinforce the message that sizes bit-width match offsets'
felipecrv c13b222
Columnar.rst: Turn the invariants into a relation between offsets and…
felipecrv dd8991a
Columnar.rst: Don't say that logical types have multiple physical lay…
felipecrv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the singular. There is no disjunction in Arrow (unlike Parquet) between "logical" data type and physical layout. ListView and StringView are simply distinct types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change this back to singular and all the other places I've changed it. But in the future, the "logical data type" terminology should probably be removed altogether because it's very confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree with that. The spec was often confusing to me at the start.