GH-37936: [CI] Fix integration testing in rc-verify nightly builds #37933

pitrou · 2023-09-28T13:23:45Z

Closes: [CI] Fix integration testing in rc-verify nightly builds #37936

github-actions · 2023-09-28T13:24:12Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

pitrou · 2023-09-28T13:24:44Z

@github-actions crossbow submit -g verify-rc-source

pitrou · 2023-09-28T14:12:39Z

@github-actions crossbow submit -g verify-rc-source

pitrou · 2023-09-28T15:10:29Z

@github-actions crossbow submit verify-rc-source-integration-macos*

pitrou · 2023-09-28T15:15:00Z

@github-actions crossbow submit verify-rc-source-integration-macos*

pitrou · 2023-09-28T15:48:28Z

@github-actions crossbow submit verify-rc-source-integration*

github-actions · 2023-09-28T15:51:03Z

Revision: 758cf86

Submitted crossbow builds: ursacomputing/crossbow @ actions-4e7dde6d23

Task	Status
verify-rc-source-integration-linux-almalinux-8-amd64
verify-rc-source-integration-linux-conda-latest-amd64
verify-rc-source-integration-linux-ubuntu-20.04-amd64
verify-rc-source-integration-linux-ubuntu-22.04-amd64
verify-rc-source-integration-macos-amd64
verify-rc-source-integration-macos-arm64
verify-rc-source-integration-macos-conda-amd64

pitrou · 2023-09-28T16:03:46Z

Unfortunately the verify-rc scripts are so slow and so unstable that it's difficult to get a clear idea of successes and failures.

@kou Are you able to review this?

pitrou · 2023-09-28T16:09:31Z

I see a lot of spurious "permission denied" at the end of the macOS arm64 integration build (otherwise successful):
https://github.com/ursacomputing/crossbow/actions/runs/6341262518/job/17224519021#step:4:6375

kou · 2023-09-28T20:43:12Z

In general, these changes look good. But there are some failures. For example:

verify-rc-source-integration-linux-almalinux-8-amd64

https://github.com/ursacomputing/crossbow/actions/runs/6341261220/job/17224514818#step:6:584

/arrow/go/arrow/internal/cdata_integration /arrow/go /arrow /
go: downloading golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
go: downloading golang.org/x/sys v0.12.0
go: downloading github.com/google/flatbuffers v23.5.26+incompatible
go: downloading github.com/klauspost/compress v1.16.7
go: downloading github.com/pierrec/lz4/v4 v4.1.18
go: downloading github.com/goccy/go-json v0.10.2
go: downloading github.com/zeebo/xxh3 v1.0.2
go: downloading github.com/klauspost/cpuid/v2 v2.2.5
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.

I can help fixing remaining failures in the next week.

pitrou · 2023-09-28T20:55:14Z

In general, these changes look good. But there are some failures. For example:

verify-rc-source-integration-linux-almalinux-8-amd64

I noticed that one, but I have no idea what the actual issue is, and whether it's related to these changes.

@zeroshade

zeroshade · 2023-10-05T20:46:38Z

@pitrou @kou Starting with go-1.18, go will attempt to stamp version control information in any binary that is built with the go toolchain. I'm guessing that the config setting up the env isn't maintaining the .git folder after the clone or something so it's unable to find the vcs info that it wants to try to stamp the binary. If there's a reason why we're not maintaining the vcs info in the file system for the verification, then it probably makes the most sense to just add the -buildvcs=false argument to the build command for the integration test binaries. we're not distributing the binaries built with the verification scripts anyways, so I don't see any problem with disabling the vcs stamping

pitrou · 2023-10-09T14:09:15Z

@github-actions crossbow submit verify-rc-source-integration*

pitrou · 2023-10-09T14:09:59Z

Ok, I think I have fixed the Go issue (it works locally), but we'll have to wait a couple hours for the Crossbow results now.

github-actions · 2023-10-09T14:12:19Z

Revision: 42f2f3f

Submitted crossbow builds: ursacomputing/crossbow @ actions-51aa7dd70b

Task	Status
verify-rc-source-integration-linux-almalinux-8-amd64
verify-rc-source-integration-linux-conda-latest-amd64
verify-rc-source-integration-linux-ubuntu-20.04-amd64
verify-rc-source-integration-linux-ubuntu-22.04-amd64
verify-rc-source-integration-macos-amd64
verify-rc-source-integration-macos-arm64
verify-rc-source-integration-macos-conda-amd64

pitrou · 2023-10-09T14:12:50Z

@github-actions crossbow submit -g verify-rc-source

github-actions · 2023-10-09T14:16:30Z

Revision: 42f2f3f

Submitted crossbow builds: ursacomputing/crossbow @ actions-1118476133

Task	Status
verify-rc-source-cpp-linux-almalinux-8-amd64
verify-rc-source-cpp-linux-conda-latest-amd64
verify-rc-source-cpp-linux-ubuntu-20.04-amd64
verify-rc-source-cpp-linux-ubuntu-22.04-amd64
verify-rc-source-cpp-macos-amd64
verify-rc-source-cpp-macos-arm64
verify-rc-source-cpp-macos-conda-amd64
verify-rc-source-csharp-linux-almalinux-8-amd64
verify-rc-source-csharp-linux-conda-latest-amd64
verify-rc-source-csharp-linux-ubuntu-20.04-amd64
verify-rc-source-csharp-linux-ubuntu-22.04-amd64
verify-rc-source-csharp-macos-amd64
verify-rc-source-csharp-macos-arm64
verify-rc-source-go-linux-almalinux-8-amd64
verify-rc-source-go-linux-conda-latest-amd64
verify-rc-source-go-linux-ubuntu-20.04-amd64
verify-rc-source-go-linux-ubuntu-22.04-amd64
verify-rc-source-go-macos-amd64
verify-rc-source-go-macos-arm64
verify-rc-source-integration-linux-almalinux-8-amd64
verify-rc-source-integration-linux-conda-latest-amd64
verify-rc-source-integration-linux-ubuntu-20.04-amd64
verify-rc-source-integration-linux-ubuntu-22.04-amd64
verify-rc-source-integration-macos-amd64
verify-rc-source-integration-macos-arm64
verify-rc-source-integration-macos-conda-amd64
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64
verify-rc-source-js-linux-almalinux-8-amd64
verify-rc-source-js-linux-conda-latest-amd64
verify-rc-source-js-linux-ubuntu-20.04-amd64
verify-rc-source-js-linux-ubuntu-22.04-amd64
verify-rc-source-js-macos-amd64
verify-rc-source-js-macos-arm64
verify-rc-source-python-linux-almalinux-8-amd64
verify-rc-source-python-linux-conda-latest-amd64
verify-rc-source-python-linux-ubuntu-20.04-amd64
verify-rc-source-python-linux-ubuntu-22.04-amd64
verify-rc-source-python-macos-amd64
verify-rc-source-python-macos-arm64
verify-rc-source-python-macos-conda-amd64
verify-rc-source-ruby-linux-almalinux-8-amd64
verify-rc-source-ruby-linux-conda-latest-amd64
verify-rc-source-ruby-linux-ubuntu-20.04-amd64
verify-rc-source-ruby-linux-ubuntu-22.04-amd64
verify-rc-source-ruby-macos-amd64
verify-rc-source-ruby-macos-arm64
verify-rc-source-windows

pitrou · 2023-10-09T16:26:36Z

I'm sorry, but I think it's pointless to wait for all those integration tasks that are failing for unrelated reasons. I will merge this CI, as it does make things better anyway.

conbench-apache-arrow · 2023-10-10T20:27:36Z

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 832511a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

…lds (apache#37933) * Closes: apache#37936 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>

github-actions bot added the awaiting review Awaiting review label Sep 28, 2023

This comment was marked as outdated.

Sign in to view

pitrou force-pushed the verify-rc-integration branch from 3986702 to 73351bb Compare September 28, 2023 14:09

github-actions bot added the Component: Go label Sep 28, 2023

pitrou changed the title ~~[CI] Fix release verification nightly builds~~ [CI] Fix integration testing in rc-verify nightly builds Sep 28, 2023

pitrou changed the title ~~[CI] Fix integration testing in rc-verify nightly builds~~ GH-37936: [CI] Fix integration testing in rc-verify nightly builds Sep 28, 2023

This comment was marked as outdated.

Sign in to view

pitrou marked this pull request as ready for review September 28, 2023 16:03

pitrou requested review from assignUser, kou, raulcd and zeroshade as code owners September 28, 2023 16:03

pitrou added 4 commits October 9, 2023 15:46

[CI] Fix release verification nightly builds

cba41cb

Fix DLL suffix on macOS

626a20d

Build C Data Interface testing bridge for Go

48b636d

Hopefully fix Go build issue

42f2f3f

pitrou force-pushed the verify-rc-integration branch from 758cf86 to 42f2f3f Compare October 9, 2023 14:04

pitrou merged commit 832511a into apache:main Oct 9, 2023
27 of 29 checks passed

pitrou removed the awaiting review Awaiting review label Oct 9, 2023

pitrou deleted the verify-rc-integration branch October 9, 2023 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-37936: [CI] Fix integration testing in rc-verify nightly builds #37933

GH-37936: [CI] Fix integration testing in rc-verify nightly builds #37933

pitrou commented Sep 28, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Sep 28, 2023

pitrou commented Sep 28, 2023

This comment was marked as outdated.

pitrou commented Sep 28, 2023

This comment was marked as outdated.

pitrou commented Sep 28, 2023

This comment was marked as outdated.

pitrou commented Sep 28, 2023

This comment was marked as outdated.

pitrou commented Sep 28, 2023

github-actions bot commented Sep 28, 2023 •

edited by kou

Loading

pitrou commented Sep 28, 2023 •

edited

Loading

pitrou commented Sep 28, 2023 •

edited

Loading

kou commented Sep 28, 2023

pitrou commented Sep 28, 2023

zeroshade commented Oct 5, 2023

pitrou commented Oct 9, 2023

pitrou commented Oct 9, 2023

github-actions bot commented Oct 9, 2023

pitrou commented Oct 9, 2023

github-actions bot commented Oct 9, 2023

pitrou commented Oct 9, 2023

conbench-apache-arrow bot commented Oct 10, 2023

GH-37936: [CI] Fix integration testing in rc-verify nightly builds #37933

GH-37936: [CI] Fix integration testing in rc-verify nightly builds #37933

Conversation

pitrou commented Sep 28, 2023 • edited by github-actions bot Loading

github-actions bot commented Sep 28, 2023

pitrou commented Sep 28, 2023

This comment was marked as outdated.

pitrou commented Sep 28, 2023

This comment was marked as outdated.

pitrou commented Sep 28, 2023

This comment was marked as outdated.

pitrou commented Sep 28, 2023

This comment was marked as outdated.

pitrou commented Sep 28, 2023

github-actions bot commented Sep 28, 2023 • edited by kou Loading

pitrou commented Sep 28, 2023 • edited Loading

pitrou commented Sep 28, 2023 • edited Loading

kou commented Sep 28, 2023

pitrou commented Sep 28, 2023

zeroshade commented Oct 5, 2023

pitrou commented Oct 9, 2023

pitrou commented Oct 9, 2023

github-actions bot commented Oct 9, 2023

pitrou commented Oct 9, 2023

github-actions bot commented Oct 9, 2023

pitrou commented Oct 9, 2023

conbench-apache-arrow bot commented Oct 10, 2023

pitrou commented Sep 28, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Sep 28, 2023 •

edited by kou

Loading

pitrou commented Sep 28, 2023 •

edited

Loading

pitrou commented Sep 28, 2023 •

edited

Loading