Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Python][Docs] Fix default for use_compliant_nested_type in parquet write_table docstring #38471

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

sfc-gh-jliang
Copy link
Contributor

@sfc-gh-jliang sfc-gh-jliang commented Oct 26, 2023

Rationale for this change

the default value of use_compliant_nested_type is True

What changes are included in this PR?

Change the comment from False to True

Are these changes tested?

No, it just changed the comment

Are there any user-facing changes?

No

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@mapleFU
Copy link
Member

mapleFU commented Oct 26, 2023

You can change the Title to MINOR: [Python][Docs] Update comment in core.py

@sfc-gh-jliang sfc-gh-jliang changed the title Update comment in core.py MINOR: [Python][Docs] Update comment in core.py Oct 26, 2023
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also cc @jorisvandenbossche @AlenkaF

Context: this is edit in #35146 . But previous patch forgot to edit this.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 26, 2023
@jorisvandenbossche jorisvandenbossche changed the title MINOR: [Python][Docs] Update comment in core.py MINOR: [Python][Docs] Fix default for use_compliant_nested_type in parquet write_table docstring Oct 26, 2023
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 26, 2023
@jorisvandenbossche jorisvandenbossche merged commit c46fd24 into apache:main Oct 26, 2023
15 of 19 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting merge Awaiting merge label Oct 26, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c46fd24.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…rquet write_table docstring (apache#38471)

### Rationale for this change

the default value of use_compliant_nested_type is True

### What changes are included in this PR?

Change the comment from False to True

### Are these changes tested?
No, it just changed the comment

### Are there any user-facing changes?
No

Authored-by: Jiaxing Liang <58449896+sfc-gh-jliang@users.noreply.github.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…rquet write_table docstring (apache#38471)

### Rationale for this change

the default value of use_compliant_nested_type is True

### What changes are included in this PR?

Change the comment from False to True

### Are these changes tested?
No, it just changed the comment

### Are there any user-facing changes?
No

Authored-by: Jiaxing Liang <58449896+sfc-gh-jliang@users.noreply.github.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants