GH-38766: [R] Add timeout option to try_download #38767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
changed the title
|
|
jonkeane
reviewed
Nov 17, 2023
r/tools/nixlibs.R
Outdated
Comment on lines
82
to
83
| # We download some fairly large files, so ensure the timeout is set appropriately | ||
| opts <- options(timeout = max(300, getOption("timeout"))) |
There was a problem hiding this comment.
How big are our binaries? We could back of the envelope math for downloading that in worst-case speed. You might have already done this calculation, if so, would be nice to add that to the comment so we know
There was a problem hiding this comment.
Currently one the windows one is 70 MB. I added a note!
github-actions
bot
added
awaiting changes
github-actions
bot
added
Component: R
awaiting change review
github-actions
bot
added
awaiting change review
assignUser
approved these changes
Nov 18, 2023
|
@github-actions crossbow submit r-binary-packages (I don't think any of the PR CI jobs exercise this code path, I will merge after) |
|
Revision: 49e2a0b Submitted crossbow builds: ursacomputing/crossbow @ actions-4430486f55
|
|
The failure is unrelated (seems to be a fluke in r-lib setup-r-dependencies during pak install on 4.2, hasn't happened in the nightlies so 🤷 ) |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit c6682f1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Nov 23, 2023
### Rationale for this change The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html ### What changes are included in this PR? The timeout value is temporarily increased according to guidance in the help for `download.file()` ### Are these changes tested? Yes, this code runs during install for at least some CI jobs (also used to download cmake) ### Are there any user-facing changes? No * Closes: apache#38766 Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Co-authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
assignUser
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Nov 28, 2023
### Rationale for this change The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html ### What changes are included in this PR? The timeout value is temporarily increased according to guidance in the help for `download.file()` ### Are these changes tested? Yes, this code runs during install for at least some CI jobs (also used to download cmake) ### Are there any user-facing changes? No * Closes: apache#38766 Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Co-authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
raulcd
pushed a commit
that referenced
this pull request
Nov 28, 2023
### Rationale for this change The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html ### What changes are included in this PR? The timeout value is temporarily increased according to guidance in the help for `download.file()` ### Are these changes tested? Yes, this code runs during install for at least some CI jobs (also used to download cmake) ### Are there any user-facing changes? No * Closes: #38766 Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Co-authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
assignUser
pushed a commit
to assignUser/arrow
that referenced
this pull request
Dec 1, 2023
### Rationale for this change The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html ### What changes are included in this PR? The timeout value is temporarily increased according to guidance in the help for `download.file()` ### Are these changes tested? Yes, this code runs during install for at least some CI jobs (also used to download cmake) ### Are there any user-facing changes? No * Closes: apache#38766 Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Co-authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html ### What changes are included in this PR? The timeout value is temporarily increased according to guidance in the help for `download.file()` ### Are these changes tested? Yes, this code runs during install for at least some CI jobs (also used to download cmake) ### Are there any user-facing changes? No * Closes: apache#38766 Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Co-authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The download of static libraries during installation might be causing an install failure: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/arrow-00install.html
What changes are included in this PR?
The timeout value is temporarily increased according to guidance in the help for
download.file()Are these changes tested?
Yes, this code runs during install for at least some CI jobs (also used to download cmake)
Are there any user-facing changes?
No