GH-39113: [Integration][Flight][Java] Fix occasional failure starting Java server #39115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arting Java server
|
|
|
I'm not sure this will actually fix the issue (perhaps the occasional failures have an other cause?), but we won't be able to judge immediately, since it's sporadic. |
|
👍 LGTM! |
|
Thanks @danepitkin ! I'll merge this. |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 9fdcc60. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…arting Java server (apache#39115) ### Rationale for this change The "perfdata" feature in the JVM can sometimes cause spurious warnings or failures trying to start the Integration Flight server: ``` ################# FAILURES ################# FAILED TEST: decimal Java producing, Java consuming <class 'RuntimeError'>: Flight-Java server did not start properly, stdout: Warning: [0.002s][warning][perf,memops] Cannot use file /tmp/hsperfdata_root/55221 because it is locked by another process (errno = 11) stderr: ``` ### What changes are included in this PR? Disable the perfdata feature when starting the JVM for integration tests. ### Are these changes tested? By construction, yes. ### Are there any user-facing changes? No. * Closes: apache#39113 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The "perfdata" feature in the JVM can sometimes cause spurious warnings or failures trying to start the Integration Flight server:
What changes are included in this PR?
Disable the perfdata feature when starting the JVM for integration tests.
Are these changes tested?
By construction, yes.
Are there any user-facing changes?
No.