GH-39238:[Go] PATCH Prevents empty record to be appended to empty resultset #39239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 75c6b64. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…ty resultset (apache#39239) ### Rationale for this change When having an empty resultset, the driver tries to include an empty record referece, that cannot be scanned. So, any operation that relies on the returned Row(s) will trigger a "Index out of Range" error. ### What changes are included in this PR? We're preventing to include an invalid record (that can't be scanned) in an empty resultset ### Are these changes tested? Yes, there's a new test included ### Are there any user-facing changes? No **This PR contains a "Critical Fix".** * Closes: apache#39238 Authored-by: miguel pragier <miguel.pragier@ebnerstolz.de> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ty resultset (apache#39239) ### Rationale for this change When having an empty resultset, the driver tries to include an empty record referece, that cannot be scanned. So, any operation that relies on the returned Row(s) will trigger a "Index out of Range" error. ### What changes are included in this PR? We're preventing to include an invalid record (that can't be scanned) in an empty resultset ### Are these changes tested? Yes, there's a new test included ### Are there any user-facing changes? No **This PR contains a "Critical Fix".** * Closes: apache#39238 Authored-by: miguel pragier <miguel.pragier@ebnerstolz.de> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When having an empty resultset, the driver tries to include an empty record referece, that cannot be scanned.
So, any operation that relies on the returned Row(s) will trigger a "Index out of Range" error.
What changes are included in this PR?
We're preventing to include an invalid record (that can't be scanned) in an empty resultset
Are these changes tested?
Yes, there's a new test included
Are there any user-facing changes?
No
This PR contains a "Critical Fix".