Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-39930: [C++] Use Requires instead of Libs for system RE2 in arrow.pc #39932

Merged
merged 1 commit into from
Feb 5, 2024
Merged

GH-39930: [C++] Use Requires instead of Libs for system RE2 in arrow.pc #39932

merged 1 commit into from
Feb 5, 2024

Commits on Feb 4, 2024

  1. apacheGH-39930: [C++] Use Requires instead of Libs for system RE2 in … 

    …arrow.pc

We chose Libs{,.private} with libre2.a for system RE2 in
apacheGH-10626. Because "Require{,.private} re2" may add "-std=c++11". If
"-std=c++11" was added, users can't build Apache Arrow C++ because
Apache Arrow C++ requires C++17 or later.

But this approach doesn't work with RE2 2024-06-01 or later because it
at least requires Abseil. If we keep the Libs{,.private} approach, we
also need to add Abseil libraries to Libs{,.private}. But it's
unmaintainable.

Let's use "Requires{,.private} re2" instead of Libs{,.private}. I hope
recent re2.pc doesn't add "-std=c++11".
    @kou
    kou committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    943d927 View commit details
    Browse the repository at this point in the history