Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Docs][Java] Fix installation documentation for BOM file #39939

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

wForget
Copy link
Member

@wForget wForget commented Feb 5, 2024

Rationale for this change

We should import arrow-bom in dependencyManagement.

What changes are included in this PR?

Import arrow-bom module in dependencyManagement

Are these changes tested?

No

Are there any user-facing changes?

Documentation

@wForget
Copy link
Member Author

wForget commented Feb 5, 2024

@jduo could you please take a look?

Copy link
Member

@jduo jduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Feb 5, 2024
@kou kou changed the title [MINOR][DOC] Fix installation documentation for BOM file MINOR: [Docs][Java] Fix installation documentation for BOM file Feb 5, 2024
@kou
Copy link
Member

kou commented Feb 5, 2024

@github-actions crossbow submit preview-docs

Copy link

github-actions bot commented Feb 5, 2024

Revision: 7b89d31

Submitted crossbow builds: ursacomputing/crossbow @ actions-99396373bc

Task Status
preview-docs GitHub Actions

@raulcd
Copy link
Member

raulcd commented Feb 5, 2024

The failure of the preview-docs job is related to: #39942

@kou kou merged commit b63770c into apache:main Feb 19, 2024
8 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Feb 19, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b63770c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…he#39939)

### Rationale for this change

We should import `arrow-bom` in `dependencyManagement`.

### What changes are included in this PR?

Import `arrow-bom` module in `dependencyManagement`

### Are these changes tested?

No

### Are there any user-facing changes?

Documentation

Authored-by: wforget <643348094@qq.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
…he#39939)

### Rationale for this change

We should import `arrow-bom` in `dependencyManagement`.

### What changes are included in this PR?

Import `arrow-bom` module in `dependencyManagement`

### Are these changes tested?

No

### Are there any user-facing changes?

Documentation

Authored-by: wforget <643348094@qq.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants