MINOR: [Python] Avoid failing pyarrow compute test on leap day #40288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Python
awaiting committer review
|
FTR: This is the error: [ 887s] _____________________________ test_count_distinct ______________________________
[ 887s] [gw1] linux -- Python 3.9.18 /usr/bin/python3.9
[ 887s]
[ 887s] def test_count_distinct():
[ 887s] seed = datetime.datetime.now()
[ 887s] > samples = [seed.replace(year=y) for y in range(1992, 2092)]
[ 887s]
[ 887s] ../../BUILDROOT/python-pyarrow-15.0.1-21.2.x86_64/usr/lib64/python3.9/site-packages/pyarrow/tests/test_compute.py:3210:
[ 887s] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[ 887s]
[ 887s] .0 = <range_iterator object at 0x7f2df4ba7f60>
[ 887s]
[ 887s] > samples = [seed.replace(year=y) for y in range(1992, 2092)]
[ 887s] E ValueError: day is out of range for month
[ 887s]
[ 887s] ../../BUILDROOT/python-pyarrow-15.0.1-21.2.x86_64/usr/lib64/python3.9/site-packages/pyarrow/tests/test_compute.py:3210: ValueError |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d3ae788. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…e#40288) ### Rationale for this change Avoid creation of invalid datetimes when it is Feb 29, avoiding to have to investigate every four years why a lot of tests are failing Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Avoid creation of invalid datetimes when it is Feb 29, avoiding to have to investigate every four years why a lot of tests are failing