Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40495: [GLib] Use G_DECLARE_DERIVABLE_TYPE() #40497

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

kou
Copy link
Member

@kou kou commented Mar 13, 2024

Rationale for this change

Using G_DECLARE_DERIVABLE_TYPE() or its family is the recommended way to declare a class (type).

What changes are included in this PR?

Replace raw #defines with G_DECLARE_DERIVABLE_TYPE().

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #40495 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Mar 13, 2024

+1

@kou kou merged commit d7a3f6d into apache:main Mar 13, 2024
8 checks passed
@kou kou deleted the glib-declare-derivable-type branch March 13, 2024 08:29
@kou kou removed the awaiting committer review Awaiting committer review label Mar 13, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d7a3f6d.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant