Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Update R packaging steps to reflect current release process #40651

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

thisisnic
Copy link
Member

Rationale for this change

R release process has changed a little and needs documenting

What changes are included in this PR?

Documented changes

Are these changes tested?

No

Are there any user-facing changes?

No

@thisisnic thisisnic requested a review from assignUser as a code owner March 18, 2024 21:46
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor note, looks good though.

r/PACKAGING.md Outdated Show resolved Hide resolved
Co-authored-by: Bryce Mecum <petridish@gmail.com>
@amoeba
Copy link
Member

amoeba commented Mar 19, 2024

LGTM.

@thisisnic thisisnic changed the title [MINOR][R] Update R packaging steps to reflect current release process MINOR: [R] Update R packaging steps to reflect current release process Mar 20, 2024
@thisisnic thisisnic merged commit 921863f into main Mar 20, 2024
20 checks passed
@thisisnic thisisnic removed the awaiting committer review Awaiting committer review label Mar 20, 2024
@thisisnic thisisnic deleted the thisisnic-patch-1 branch March 20, 2024 02:02
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 921863f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants