Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [CI] Avoid docker-compose on Azure #40972

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Apr 3, 2024

Rationale for this change

Same as PR #40949, but for Crossbow builds hosted on Azure Pipelines.

Are these changes tested?

Yes, they fix CI tests.

Are there any user-facing changes?

No.

@pitrou
Copy link
Member Author

pitrou commented Apr 3, 2024

@github-actions crossbow submit conda-clean test-debian-12-python-3-amd64

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Revision: 1d321c4

Submitted crossbow builds: ursacomputing/crossbow @ actions-2c5940b7be

Task Status
conda-clean Azure
test-debian-12-python-3-amd64 Azure

@pitrou pitrou marked this pull request as ready for review April 3, 2024 08:53
@pitrou pitrou requested review from assignUser, kou and raulcd as code owners April 3, 2024 08:53
@pitrou
Copy link
Member Author

pitrou commented Apr 3, 2024

@assignUser @kou Can you advise?

@@ -61,7 +61,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5.1.0
with:
python-version: '3.12'
python-version: '3.9'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for the docker-compose dependencies to install properly.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 3, 2024
@pitrou pitrou merged commit 469430f into apache:main Apr 3, 2024
8 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Apr 3, 2024
@pitrou pitrou deleted the azure-docker branch April 3, 2024 11:52
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting everything going again! Sorry for the late review.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 3, 2024
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 469430f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
### Rationale for this change

Same as PR apache#40949, but for Crossbow builds hosted on Azure Pipelines.

### Are these changes tested?

Yes, they fix CI tests.

### Are there any user-facing changes?

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 4, 2024
Same as PR apache#40949, but for Crossbow builds hosted on Azure Pipelines.

Yes, they fix CI tests.

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
Same as PR apache#40949, but for Crossbow builds hosted on Azure Pipelines.

Yes, they fix CI tests.

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
Same as PR apache#40949, but for Crossbow builds hosted on Azure Pipelines.

Yes, they fix CI tests.

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
### Rationale for this change

Same as PR apache#40949, but for Crossbow builds hosted on Azure Pipelines.

### Are these changes tested?

Yes, they fix CI tests.

### Are there any user-facing changes?

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting committer review Awaiting committer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants