Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41480: [Python] Update Python development guide about components being enabled by default based on Arrow C++ #41705

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented May 17, 2024

Rationale for this change

Follow-up on #41494 to update the Python development guide to reflect the change in how PyArrow is build (defaults for the various PYARROW_BUILD_<component> are now set based on the ARROW_<component> setting. The current PYARROW_WITH_<component> environment variables are kept working to allow to override this default)

…ents being enabled by default based on Arrow C++
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 17, 2024
@rok
Copy link
Member

rok commented May 17, 2024

Thanks for documenting Joris! Super happy this won't cause friction anymore.

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting merge Awaiting merge labels May 17, 2024
@jorisvandenbossche jorisvandenbossche merged commit aea10c2 into apache:main Jun 13, 2024
9 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting changes Awaiting changes label Jun 13, 2024
@jorisvandenbossche jorisvandenbossche deleted the gh-41480-pyarrow-build-config-docs branch June 13, 2024 12:44
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit aea10c2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants