-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [C++][CI] Work around bug in conda-forge benchmark package #41987
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
@github-actions crossbow submit -g cpp |
Revision: 58c50a2 Submitted crossbow builds: ursacomputing/crossbow @ actions-7ac715f1cb |
@github-actions crossbow submit test-conda-* |
Revision: 9752410 Submitted crossbow builds: ursacomputing/crossbow @ actions-4fa8bba55b |
@kou @assignUser @raulcd It would be nice to review this quickly as it fixes a couple CI jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning the env to avoid the wrong version sounds sensible to me.
In case someone else is also looking for an example of the error, you can see a failing job here: https://github.com/apache/arrow/actions/runs/9386853022/job/25848402934
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, makes sense!
…ache#41987) ### Rationale for this change Work around bug in version 1.8.4 of the benchmark package: conda-forge/benchmark-feedstock#36 ### Are these changes tested? By regular CI jobs. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9ee6ea7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Work around bug in version 1.8.4 of the benchmark package: conda-forge/benchmark-feedstock#36
Are these changes tested?
By regular CI jobs.
Are there any user-facing changes?
No.