Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++][CI] Work around bug in conda-forge benchmark package #41987

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jun 5, 2024

Rationale for this change

Work around bug in version 1.8.4 of the benchmark package: conda-forge/benchmark-feedstock#36

Are these changes tested?

By regular CI jobs.

Are there any user-facing changes?

No.

Copy link

github-actions bot commented Jun 5, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added the awaiting review Awaiting review label Jun 5, 2024
@pitrou
Copy link
Member Author

pitrou commented Jun 5, 2024

@github-actions crossbow submit -g cpp

@pitrou pitrou force-pushed the benchmark-conda branch from 58c50a2 to 9752410 Compare June 5, 2024 15:26
Copy link

github-actions bot commented Jun 5, 2024

Revision: 58c50a2

Submitted crossbow builds: ursacomputing/crossbow @ actions-7ac715f1cb

Task Status
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

@pitrou pitrou changed the title [C++][CI] Try to workaround bug in conda-forge benchmark package MINOR: [C++][CI] Try to workaround bug in conda-forge benchmark package Jun 5, 2024
@pitrou
Copy link
Member Author

pitrou commented Jun 5, 2024

@github-actions crossbow submit test-conda-*

Copy link

github-actions bot commented Jun 5, 2024

Revision: 9752410

Submitted crossbow builds: ursacomputing/crossbow @ actions-4fa8bba55b

Task Status
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions

@pitrou pitrou marked this pull request as ready for review June 5, 2024 15:55
@pitrou pitrou requested review from assignUser, kou and raulcd as code owners June 5, 2024 15:55
@pitrou pitrou changed the title MINOR: [C++][CI] Try to workaround bug in conda-forge benchmark package MINOR: [C++][CI] Work around bug in conda-forge benchmark package Jun 5, 2024
@pitrou
Copy link
Member Author

pitrou commented Jun 5, 2024

@kou @assignUser @raulcd It would be nice to review this quickly as it fixes a couple CI jobs.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning the env to avoid the wrong version sounds sensible to me.
In case someone else is also looking for an example of the error, you can see a failing job here: https://github.com/apache/arrow/actions/runs/9386853022/job/25848402934

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 5, 2024
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense!

@assignUser assignUser added this to the 17.0.0 milestone Jun 5, 2024
@assignUser assignUser merged commit 9ee6ea7 into apache:main Jun 5, 2024
27 of 29 checks passed
@assignUser assignUser removed the awaiting merge Awaiting merge label Jun 5, 2024
@pitrou pitrou deleted the benchmark-conda branch June 5, 2024 17:06
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Jun 5, 2024
…ache#41987)

### Rationale for this change

Work around bug in version 1.8.4 of the benchmark package: conda-forge/benchmark-feedstock#36

### Are these changes tested?

By regular CI jobs.

### Are there any user-facing changes?

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9ee6ea7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants