Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43048: [JAVA] Fix IndexOutOfBoundsException message by reporting index correctly #43049

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

l-wang
Copy link
Contributor

@l-wang l-wang commented Jun 25, 2024

The detailed message for IndexOutOfBoundsException should report the srcIndex that was previously passed to the isOutOfBounds() check

Fixes #43048

The detailed message for IndexOutOfBoundsException should report the
srcIndex that was previously passed to the isOutOfBounds() check
@l-wang l-wang requested a review from lidavidm as a code owner June 25, 2024 18:25
Copy link

⚠️ GitHub issue #43048 has been automatically assigned in GitHub to PR creator.

@vibhatha
Copy link
Collaborator

@lidavidm could you approve the workflows?

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 26, 2024
@lidavidm lidavidm merged commit 3834a38 into apache:main Jun 26, 2024
17 checks passed
@lidavidm lidavidm removed the awaiting committer review Awaiting committer review label Jun 26, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 26, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3834a38.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Jul 9, 2024
…ting index correctly (apache#43049)

The detailed message for IndexOutOfBoundsException should report the srcIndex that was previously passed to the isOutOfBounds() check

Fixes apache#43048
* GitHub Issue: apache#43048

Authored-by: Alexandra Wang <alex.wang@dremio.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@vibhatha
Copy link
Collaborator

@github-actions crossbow submit -g java

Copy link

Revision: e38b506

Submitted crossbow builds: ursacomputing/crossbow @ actions-1add5c337f

Task Status
java-jars GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Incorrect message for IndexOutOfBoundsException in ArrowBuf.setBytes()
3 participants