-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [CI] Replace docker-compose with docker compose
#43566
Conversation
"docker-compose" is not available on some CI images anymore, switch to the Docker built-in "compose" command.
@github-actions crossbow submit example minimal test-r-* |
Revision: dbb9e28 Submitted crossbow builds: ursacomputing/crossbow @ actions-34ce7865d9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5710638. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…"docker compose" (#43575) ### Rationale for this change This is a follow-on to #43566 which was merged earlier today. See #43570 for more detail on the entire set of changes. ### What changes are included in this PR? - Replace instances where we call or document calling `docker-compose` with `docker compose`. ### Are these changes tested? Yes. ### Are there any user-facing changes? This PR includes the require user-facing changes to document things. * GitHub Issue: #43570 Lead-authored-by: Bryce Mecum <petridish@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
"docker-compose" is not available on some CI images anymore, switch to the Docker built-in "compose" command.