-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43301: [C++][Parquet] Enhance the comment for ColumnReader/Decoder #44003
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
@@ -2225,10 +2245,9 @@ class ByteArrayDictionaryRecordReader final : public TypedRecordReader<ByteArray | |||
} else { | |||
num_decoded = this->current_decoder_->DecodeArrowNonNull( | |||
static_cast<int>(values_to_read), &builder_); | |||
|
|||
/// Flush values since they have been copied into the builder | |||
ResetValues(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a logical change but I don't think it would matter 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a few suggestions
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Would merge after ci pass |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cd50c32. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 102 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ecoder (apache#44003) ### Rationale for this change Enhance the comment for ColumnReader/Decoder ### What changes are included in this PR? Enhance the comment for ColumnReader/Decoder ### Are these changes tested? no need ### Are there any user-facing changes? no * GitHub Issue: apache#43301 Lead-authored-by: mwish <1506118561@qq.com> Co-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: Antoine Pitrou <pitrou@free.fr> Signed-off-by: mwish <maplewish117@gmail.com>
Rationale for this change
Enhance the comment for ColumnReader/Decoder
What changes are included in this PR?
Enhance the comment for ColumnReader/Decoder
Are these changes tested?
no need
Are there any user-facing changes?
no