Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43301: [C++][Parquet] Enhance the comment for ColumnReader/Decoder #44003

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Sep 8, 2024

Rationale for this change

Enhance the comment for ColumnReader/Decoder

What changes are included in this PR?

Enhance the comment for ColumnReader/Decoder

Are these changes tested?

no need

Are there any user-facing changes?

no

@mapleFU mapleFU requested a review from wgtmac as a code owner September 8, 2024 13:09
Copy link

github-actions bot commented Sep 8, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@mapleFU
Copy link
Member Author

mapleFU commented Sep 8, 2024

@wgtmac @pitrou would you mind take a look? This just edit the comments

@@ -2225,10 +2245,9 @@ class ByteArrayDictionaryRecordReader final : public TypedRecordReader<ByteArray
} else {
num_decoded = this->current_decoder_->DecodeArrowNonNull(
static_cast<int>(values_to_read), &builder_);

/// Flush values since they have been copied into the builder
ResetValues();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a logical change but I don't think it would matter 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 8, 2024
@mapleFU mapleFU changed the title [C++][Parquet] Enhance the comment for ColumnReader/Decoder GH-43301: [C++][Parquet] Enhance the comment for ColumnReader/Decoder Sep 8, 2024
@mapleFU mapleFU requested a review from pitrou September 9, 2024 09:36
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a few suggestions

Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@mapleFU
Copy link
Member Author

mapleFU commented Sep 9, 2024

Would merge after ci pass

@mapleFU mapleFU merged commit cd50c32 into apache:main Sep 9, 2024
34 of 35 checks passed
@mapleFU mapleFU deleted the more-notes-in-column-reader branch September 9, 2024 14:21
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cd50c32.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 102 possible false positives for unstable benchmarks that are known to sometimes produce them.

khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
…ecoder (apache#44003)

### Rationale for this change

Enhance the comment for ColumnReader/Decoder

### What changes are included in this PR?

Enhance the comment for ColumnReader/Decoder

### Are these changes tested?

no need 

### Are there any user-facing changes?

no

* GitHub Issue: apache#43301

Lead-authored-by: mwish <1506118561@qq.com>
Co-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants