-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43879: [Go] Remove go related code #44293
Conversation
|
@github-actions crossbow submit verify-rc-source-* |
Revision: ae01d5c Submitted crossbow builds: ursacomputing/crossbow @ actions-fe8b0944c0 |
The CI failures are unrelated and I've triggered the swift jobs to validate they still work even if we remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This reverts commit 9ee7be2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am merging this in preparation for the release.
👍
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e62fbaa. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Adapt the documentation to the new url to reflect the change made in #44293 (moving the Go libraries to a separate repository) ### What changes are included in this PR? I updated the url to the Go libraries in the README.md file ### Are these changes tested? N/A ### Are there any user-facing changes? N/A Authored-by: GeniusTimo <mail@geniustimo.de> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
### What changes were proposed in this pull request? The Arrow Go has its own repo now, see apache/arrow#44293 ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Closes #83 from haoxins/arrow-18. Authored-by: Xin Hao <haoxinst@gmail.com> Signed-off-by: Martin Grund <martin.grund@databricks.com>
Rationale for this change
Go code has been mode to its own repository at https://github.com/apache/arrow-go
What changes are included in this PR?
Removing the folder
go/
from the https://github.com/apache/arrow repositoryAre these changes tested?
I'll validate on CI there's no failures
Are there any user-facing changes?
The Go code is no longer present on the Arrow repository.