Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43879: [Go] Remove go related code #44293

Merged
merged 3 commits into from
Oct 7, 2024
Merged

GH-43879: [Go] Remove go related code #44293

merged 3 commits into from
Oct 7, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Oct 3, 2024

Rationale for this change

Go code has been mode to its own repository at https://github.com/apache/arrow-go

What changes are included in this PR?

Removing the folder go/ from the https://github.com/apache/arrow repository

Are these changes tested?

I'll validate on CI there's no failures

Are there any user-facing changes?

The Go code is no longer present on the Arrow repository.

@raulcd raulcd requested a review from zeroshade as a code owner October 3, 2024 10:00
Copy link

github-actions bot commented Oct 3, 2024

⚠️ GitHub issue #43879 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting committer review Awaiting committer review Component: Go Component: Documentation and removed awaiting committer review Awaiting committer review labels Oct 3, 2024
@raulcd
Copy link
Member Author

raulcd commented Oct 3, 2024

@github-actions crossbow submit verify-rc-source-*

@github-actions github-actions bot added the awaiting review Awaiting review label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Revision: ae01d5c

Submitted crossbow builds: ursacomputing/crossbow @ actions-fe8b0944c0

Task Status
verify-rc-source-cpp-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-cpp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-cpp-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-cpp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-cpp-macos-amd64 GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-cpp-macos-conda-amd64 GitHub Actions
verify-rc-source-csharp-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-csharp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-csharp-macos-amd64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions
verify-rc-source-integration-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-integration-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions
verify-rc-source-js-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-js-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-js-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-js-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-js-macos-amd64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions
verify-rc-source-python-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-python-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions
verify-rc-source-ruby-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-ruby-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions
verify-rc-source-windows GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Oct 3, 2024

The CI failures are unrelated and I've triggered the swift jobs to validate they still work even if we remove the go/ subfolder.
@zeroshade @kou I think this is ok to be merged
I'll revert 9ee7be2 before merging

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 3, 2024
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am merging this in preparation for the release.
👍

@raulcd raulcd merged commit e62fbaa into apache:main Oct 7, 2024
7 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 7, 2024
@raulcd raulcd mentioned this pull request Oct 7, 2024
@raulcd raulcd deleted the GH-43879 branch October 7, 2024 09:14
@github-actions github-actions bot added the awaiting changes Awaiting changes label Oct 7, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e62fbaa.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

kou pushed a commit that referenced this pull request Oct 10, 2024
### Rationale for this change
Adapt the documentation to the new url to reflect the change made in #44293 (moving the Go libraries to a separate repository)

### What changes are included in this PR?
I updated the url to the Go libraries in the README.md file

### Are these changes tested?
N/A

### Are there any user-facing changes?
N/A

Authored-by: GeniusTimo <mail@geniustimo.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
grundprinzip pushed a commit to apache/spark-connect-go that referenced this pull request Oct 24, 2024
### What changes were proposed in this pull request?

The Arrow Go has its own repo now, see
apache/arrow#44293

### Why are the changes needed?

### Does this PR introduce _any_ user-facing change?

No
### How was this patch tested?

Closes #83 from haoxins/arrow-18.

Authored-by: Xin Hao <haoxinst@gmail.com>
Signed-off-by: Martin Grund <martin.grund@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants