Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44404: [CI] Stop running CI "push" jobs for Dependabot #44405

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 14, 2024

Rationale for this change

They are redundant. We have the same jobs for "push" and "pull_request". We don't need either of them.

What changes are included in this PR?

Ignore dependabot/** branches for "push".

We need to define not only branches: but also tags:. If we don't define tags:, the target workflows aren't trigger by tag push.

See also: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore

If you define only tags/tags-ignore or only branches/branches-ignore, the workflow won't run for events affecting the undefined Git ref. If you define neither tags/tags-ignore or branches/branches-ignore, the workflow will run for events affecting either branches or tags. If you define both branches/branches-ignore and paths/paths-ignore, the workflow will only run when both filters are satisfied.

Are these changes tested?

No. Let's try on apache/arrow main.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #44404 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 14, 2024
@kou kou force-pushed the ci-dependabot-reduce branch from d72a364 to 30fce89 Compare October 16, 2024 12:12
@kou
Copy link
Member Author

kou commented Oct 17, 2024

Let's try on main.

@kou kou merged commit 16ad979 into apache:main Oct 17, 2024
51 of 52 checks passed
@kou kou deleted the ci-dependabot-reduce branch October 17, 2024 00:07
@kou kou removed the awaiting committer review Awaiting committer review label Oct 17, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 16ad979.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant