Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44396: [CI][C++] Use setup-python on hosted runner #44411

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 15, 2024

Rationale for this change

We can't install packages by pip install with Ubuntu 24.04's pip by default.

What changes are included in this PR?

Use actions/setup-python instead. We can install packages by pip install with actions/setup-python by default.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

We can't install packages globally with Ubuntu 24.04's pip by default.
Copy link

⚠️ GitHub issue #44396 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 15, 2024
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @kou

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 15, 2024
@raulcd raulcd merged commit 04ea3d8 into apache:main Oct 15, 2024
16 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 15, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 04ea3d8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.

@kou kou deleted the ci-ubuntu-latest branch October 15, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants