Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45053: [C++] Add support for Boost 1.87.0 #45057

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

kou
Copy link
Member

@kou kou commented Dec 18, 2024

Rationale for this change

Boost 1.87.0 removed BOOST_PROCESS_V2_ASIO_NAMESPACE:
boostorg/process@e827d14

What changes are included in this PR?

Use BOOST_PROCESS_V2_NAMESPACE::net instead.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #45053 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 5ec8b64 into apache:main Dec 18, 2024
38 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Dec 18, 2024
@kou kou deleted the cpp-boost-1.87 branch December 18, 2024 05:38
lriggs pushed a commit to lriggs/arrow that referenced this pull request Dec 26, 2024
### Rationale for this change

Boost 1.87.0 removed `BOOST_PROCESS_V2_ASIO_NAMESPACE`:
boostorg/process@e827d14

### What changes are included in this PR?

Use `BOOST_PROCESS_V2_NAMESPACE::net` instead.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#45053

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants