ARROW-6744: [Rust] Publicly expose JsonEqual #5549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have an issue with exposing this but do you mind explaining your use case and why the existing Arrow types are not suitable? CPP has an extension array concept but we have not gotten that far in Rust yet. |
|
To be honest, I don't currently have a strong use case at this point in time. I was more so just trying to see if this broad idea I had was possible and ran into the trait being private before it could really culminate into anything. |
kszucs
pushed a commit
that referenced
this pull request
Oct 5, 2019
Jira Issue: https://issues.apache.org/jira/browse/ARROW-6744 As of right now, devs using arrow in their own project cannot implement the Array trait since it is bound by JsonEqual, which isn't exported publicly. I am not sure if this was done intentionally, but if not this PR will resolve the problem. Closes #5549 from kyle-mccarthy/master and squashes the following commits: fc21750 <Kyle McCarthy> ARROW-6744: Publicly expose JsonEqual Authored-by: Kyle McCarthy <kyle@creativeanvil.com> Signed-off-by: Paddy Horan <paddyhoran@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: https://issues.apache.org/jira/browse/ARROW-6744
As of right now, devs using arrow in their own project cannot implement the Array trait since it is bound by JsonEqual, which isn't exported publicly.
I am not sure if this was done intentionally, but if not this PR will resolve the problem.