ARROW-7003: [Rust] Generate flatbuffers files in docker build image #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI failure unrelated to this PR |
paddyhoran
approved these changes
Oct 28, 2019
nevi-me
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the build docker image to generate IPC source based on the flatbuffer specification.
Note that the generated files are currently not used in the build (the generated files have a
_generated.rssuffix so don't overwrite the checked in versions of the files).We cannot fully automate this until google/flatbuffers#5589 is resolved, or we figure out a workaround, but I suggest we merge this current PR since it lays the groundwork.