Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8747: [C++] Write compressed size in little-endian format for Feather V2 #7137

Closed
wants to merge 1 commit into from

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented May 9, 2020

This PR always puts the compressed size in little-endian format for Feather V2 since the reader expected the little-endian format.

Based on the discussion at #6777, this commit reads compressed_length in Feather V2 format as little-endian. However, the writer puts compressed_length in native-endian.

This PR can fix failures related to reading compressed feather format in arrow-ipc-read-write-test and arrow-feather-test.

@github-actions
Copy link

github-actions bot commented May 9, 2020

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants