ARROW-212: Change contract of PrimitiveArray to reflect its abstractness #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… apparent fromt the contract
| BooleanArray(int32_t length, const std::shared_ptr<Buffer>& data, | ||
| int32_t null_count = 0, const std::shared_ptr<Buffer>& null_bitmap = nullptr); | ||
| BooleanArray(const TypePtr& type, int32_t length, const std::shared_ptr<Buffer>& data, |
There was a problem hiding this comment.
What is the benefit of passing a TypePtr? This array should always have the same type?
There was a problem hiding this comment.
In theory it could have a different logical type (I can't think of a great example for boolean types). I'm also including it here because we still haven't established if we want to be very pedantic about not doing operations that could fail with bad_alloc (especially in constructors).
Its a slightly bigger change but I can remove the requirement for passing this type and the the other ones on primitive. I don't have a strong preference here.
There was a problem hiding this comment.
Makes sense, forgot that logical types are part of the TypePtr
|
+1, LGTM |
|
+1 |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
Depends on apache#86 Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#87 from xhochy/parquet-583 and squashes the following commits: 9f3f050 [Uwe L. Korn] Incoperate feedback 86aed44 [Uwe L. Korn] PARQUET-583: Parquet to Thrift schema conversion Change-Id: I0b255221ad1c5f47db6842b0141da27dd649ff8e
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
Depends on apache#86 Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#87 from xhochy/parquet-583 and squashes the following commits: 9f3f050 [Uwe L. Korn] Incoperate feedback 86aed44 [Uwe L. Korn] PARQUET-583: Parquet to Thrift schema conversion Change-Id: I0b255221ad1c5f47db6842b0141da27dd649ff8e
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
Depends on apache#86 Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#87 from xhochy/parquet-583 and squashes the following commits: 9f3f050 [Uwe L. Korn] Incoperate feedback 86aed44 [Uwe L. Korn] PARQUET-583: Parquet to Thrift schema conversion Change-Id: I0b255221ad1c5f47db6842b0141da27dd649ff8e
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
Depends on apache#86 Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#87 from xhochy/parquet-583 and squashes the following commits: 9f3f050 [Uwe L. Korn] Incoperate feedback 86aed44 [Uwe L. Korn] PARQUET-583: Parquet to Thrift schema conversion Change-Id: I0b255221ad1c5f47db6842b0141da27dd649ff8e
xuechendi
pushed a commit
to xuechendi/arrow
that referenced
this pull request
Aug 19, 2020
zhixingheyi-tian
referenced
this pull request
in oap-project/arrow
Feb 4, 2021
rafael-telles
pushed a commit
to rafael-telles/arrow
that referenced
this pull request
Aug 20, 2021
FlightSQL Ratification based on Community Comments (round 4)
zhztheplayer
added a commit
to zhztheplayer/arrow-1
that referenced
this pull request
Mar 11, 2022
rui-mo
pushed a commit
to rui-mo/arrow-1
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up based on #80