-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3023: Test against Ruby 3.0 #1048
Conversation
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- uses: actions/setup-ruby@v1 | ||
- uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need infra- approval to run actions that aren't official. Do you know if this one's approved?
See https://issues.apache.org/jira/browse/INFRA-21253 for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the build was able to use ruby/setup-ruby
successfully, does that mean that it was already approved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened https://issues.apache.org/jira/browse/INFRA-21366 to ask the question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the build was able to use ruby/setup-ruby successfully, does that mean that it was already approved?
No, I don't believe it does. IIUC this build ran on your fork in your account, which isn't restricted by Apache rules.
But since you got the official approval from infra we are good to go.
AVRO-3023: Test against Ruby 3.0.
Ruby 3.0 was released 12/25/2020: announcement
actions/setup-ruby
has not been updated to support Ruby 3.0. Based on this issue, it looks like ruby/setup-ruby will be preferred and we should switch to it. That action also has built-in support for dependency caching. We should consider trying that instead ofactions/cache
but I have not done that here in order to keep this change minimal.