[C++] g++ (GCC) 14.2.1 20240910 fails to compile due to -Werror=conversion #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…95, 4294967295, true, true>::value_type’ {aka ‘long unsigned int’} to ‘uint32_t’ {aka ‘unsigned int’} may change value [-Werror=conversion]
…cxx11::basic_string<char> >::const_iterator, std::vector<std::__cxx11::basic_string<char> >::const_iterator, const std::string&)’
mkmkme
approved these changes
Sep 17, 2024
Gerrit0
approved these changes
Sep 17, 2024
Gerrit0
reviewed
Sep 18, 2024
lang/c++/meson.build
Outdated
| @@ -0,0 +1,150 @@ | |||
| project('avro-cpp', 'cpp', version: '1.0', | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
If adding said tooling isn't trivial, or maybe even if it is, splitting into a second PR to make it easier to merge isn't a bad idea
There was a problem hiding this comment.
Sorry. I removed it. I didn't know PR would follow so to speak further commit.
Gerrit0
approved these changes
Sep 18, 2024
martin-g
approved these changes
Sep 23, 2024
|
Thank you, @hexagonhill ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of changed code to remove error.
int32_t checksum = crc();to
auto checksum = crc();error: conversion from ‘boost::crc_optimal<32, 79764919, 4294967295, 4294967295, true, true>::value_type’ {aka ‘long unsigned int’} to ‘uint32_t’ {aka ‘unsigned int’} may change value [-Werror=conversion]Further errors not related to avro cmake but using a meson build port was missing header in some files such that std::find and std::find_if could not be found. Thought to include them in PR.
These changes passed ./build.sh test
Thanks for the code!
Sorry for the informal request a bit busy but wanted to give back.