Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-4100: [C++] Remove boost::noncopyable and boost::any #3267

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

wgtmac
Copy link
Member

@wgtmac wgtmac commented Dec 19, 2024

What is the purpose of the change

Remove boost::noncopyable and boost::any

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Dec 19, 2024
@wgtmac
Copy link
Member Author

wgtmac commented Dec 19, 2024

cc @martin-g @mkmkme @Fokko

@@ -20,17 +20,21 @@
#define avro_Layout_hh__

#include "Config.hh"
#include <boost/noncopyable.hpp>

#include <cstddef>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be <stddef.h> because Layout.hh uses size_t rather than std::size_t?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this @wgtmac

@Fokko Fokko merged commit 6e4a568 into apache:main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants