[BEAM-13051] Fixed parameters warnings

apache · Mar 2, 2022 · 37acd46 · 37acd46
1 parent 3ece301
commit 37acd46
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py b/sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
@@ -227,13 +227,16 @@ def publish_metrics(self, result, extra_metrics: Optional[dict] = None):
     # a list of dictionaries matching the schema.
     insert_dicts = self._prepare_all_metrics(metrics, metric_id)
 
-    insert_dicts += self._prepare_extra_metrics(extra_metrics, metric_id)
+    insert_dicts += self._prepare_extra_metrics(metric_id, extra_metrics)
     if len(insert_dicts) > 0:
       for publisher in self.publishers:
         publisher.publish(insert_dicts)
 
-  def _prepare_extra_metrics(self, extra_metrics: Optional[dict], metric_id: str):
+  def _prepare_extra_metrics(
+      self, metric_id: str, extra_metrics: Optional[dict] = None):
     ts = time.time()
+    if not extra_metrics:
+      extra_metrics = {}
     return [
         Metric(ts, metric_id, v, label=k).as_dict() for k,
         v in extra_metrics.items()