Round 1 Review

- Fail if debugging is requested and we're unable to register
- Don't silently retry on 404

sdk/src/main/java/com/google/cloud/dataflow/sdk/runners/DataflowPipelineRunner.java

@@ -445,15 +445,13 @@ private void maybeRegisterDebuggee(DataflowPipelineOptions options, String uniqu
           debuggerClient.controller().debuggees().register(registerReq).execute();
       Debuggee debuggee = registerResponse.getDebuggee();
       if (debuggee.getStatus() != null && debuggee.getStatus().getIsError()) {
-        LOG.error("Error registering with debugger: {}",
+        throw new RuntimeException("Unable to register with the debugger: " +
             debuggee.getStatus().getDescription().getFormat());
-        return;
       }
 
       options.setDebuggee(debuggee);
     } catch (IOException e) {
-      System.out.println("Unable to register with debugger: " + e);
-      LOG.error("Unable to register with debugger:", e);
+      throw new RuntimeException("Unable to register with the debugger: ", e);
     }
   }
 

sdk/src/main/java/com/google/cloud/dataflow/sdk/util/Transport.java

@@ -152,10 +152,7 @@ public static Dataflow.Builder newDataflowClient(DataflowPipelineOptions options
   public static Clouddebugger.Builder newClouddebuggerClient(DataflowPipelineOptions options) {
     return new Clouddebugger.Builder(getTransport(),
         getJsonFactory(),
-        chainHttpRequestInitializer(
-            options.getGcpCredential(),
-            // Do not log 404. It clutters the output and is possible even required by the caller.
-            new RetryHttpRequestInitializer(ImmutableList.of(404))))
+        chainHttpRequestInitializer(options.getGcpCredential(), new RetryHttpRequestInitializer()))
         .setApplicationName(options.getAppName())
         .setGoogleClientRequestInitializer(options.getGoogleApiTrace());
   }