Skip to content

Commit

Permalink
Fix Fhir IO Search IT (#30158)
Browse files Browse the repository at this point in the history
* [BEAM-12550] Implement Parallelizable Skew and Kurtosis
(Skew implementation)

R: @TheNeuralBit

* fix fhirio search tests

* spotless

* reduce query count and size

* postcommit

* remove clear

---------

Co-authored-by: svetakvsundhar <svetak.sundhar@gmail.com>
  • Loading branch information
svetakvsundhar and svetak authored Jan 31, 2024
1 parent 81513f1 commit 89d1c06
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Empty file.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableMap;
import org.junit.After;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand All @@ -66,7 +65,7 @@ public static Collection<String> versions() {
private static final String BASE_STORE_ID =
"FHIR_store_search_it_" + System.currentTimeMillis() + "_" + new SecureRandom().nextInt(32);
private String fhirStoreId;
private static final int MAX_NUM_OF_SEARCHES = 50;
private static final int MAX_NUM_OF_SEARCHES = 20;
private List<FhirSearchParameter<String>> input = new ArrayList<>();
private List<FhirSearchParameter<List<Integer>>> genericParametersInput = new ArrayList<>();
private static final String KEY = "key";
Expand Down Expand Up @@ -96,9 +95,9 @@ public void setup() throws Exception {

JsonArray fhirResources =
JsonParser.parseString(bundles.get(0)).getAsJsonObject().getAsJsonArray("entry");
Map<String, String> searchParameters = ImmutableMap.of("_count", "50");
Map<String, String> searchParameters = ImmutableMap.of("_count", "20");
Map<String, List<Integer>> genericSearchParameters =
ImmutableMap.of("_count", Arrays.asList(50));
ImmutableMap.of("_count", Arrays.asList(20));

// Include a non-resource type search.
input.add(FhirSearchParameter.of("", KEY, searchParameters));
Expand Down Expand Up @@ -127,7 +126,6 @@ public void teardown() throws IOException {
}
}

@Ignore("https://github.com/apache/beam/issues/28505")
@Test
public void testFhirIOSearch() {
pipeline.getOptions().as(DirectOptions.class).setBlockOnRun(false);
Expand Down Expand Up @@ -157,7 +155,6 @@ public void testFhirIOSearch() {
pipeline.run().waitUntilFinish();
}

@Ignore("https://github.com/apache/beam/issues/28505")
@Test
public void testFhirIOSearchWithGenericParameters() {
pipeline.getOptions().as(DirectOptions.class).setBlockOnRun(false);
Expand Down

0 comments on commit 89d1c06

Please sign in to comment.