Skip to content

Commit

Permalink
Merge pull request #29994: sickbay new reshuffle test on runners that…
Browse files Browse the repository at this point in the history
… do not support it
  • Loading branch information
kennknowles authored Jan 16, 2024
2 parents c11b7c1 + cf20119 commit 96a9830
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions runners/portability/java/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ def createUlrValidatesRunnerTask = { name, environmentType, dockerImageTask = ""
// https://github.com/apache/beam/issues/20374
excludeTestsMatching 'org.apache.beam.sdk.transforms.CombineTest$BasicTests.testHotKeyCombiningWithAccumulationMode'

// TODO(https://github.com/apache/beam/issues/29973)
excludeTestsMatching 'org.apache.beam.sdk.transforms.ReshuffleTest.testReshufflePreservesMetadata'

for (String test : sickbayTests) {
excludeTestsMatching test
}
Expand Down
2 changes: 2 additions & 0 deletions runners/samza/job-server/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ def portableValidatesRunnerTask(String name, boolean docker) {
excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoTest$TimestampTests.testProcessElementSkew'
// TODO(https://github.com/apache/beam/issues/22650)
excludeTestsMatching 'org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState'
// TODO(https://github.com/apache/beam/issues/29973)
excludeTestsMatching 'org.apache.beam.sdk.transforms.ReshuffleTest.testReshufflePreservesMetadata'
}
)
}
Expand Down
2 changes: 2 additions & 0 deletions runners/spark/job-server/spark_job_server.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ def portableValidatesRunnerTask(String name, boolean streaming, boolean docker,
excludeTestsMatching 'org.apache.beam.sdk.transforms.windowing.WindowingTest'
// // Assertion error: incorrect output
excludeTestsMatching 'CombineTest$BasicTests.testHotKeyCombining'
// TODO(https://github.com/apache/beam/issues/29973)
excludeTestsMatching 'org.apache.beam.sdk.transforms.ReshuffleTest.testReshufflePreservesMetadata'
}
}
else {
Expand Down
2 changes: 2 additions & 0 deletions runners/spark/spark_runner.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@ def validatesRunnerStreaming = tasks.register("validatesRunnerStreaming", Test)
// UNBOUNDED View.CreatePCollectionView not supported
excludeTestsMatching 'org.apache.beam.sdk.transforms.ParDoTest$BundleInvariantsTests.testWatermarkUpdateMidBundle'
excludeTestsMatching 'org.apache.beam.sdk.transforms.ViewTest.testWindowedSideInputNotPresent'
// TODO(https://github.com/apache/beam/issues/29973)
excludeTestsMatching 'org.apache.beam.sdk.transforms.ReshuffleTest.testReshufflePreservesMetadata'
}

// TestStream using processing time is not supported in Spark
Expand Down

0 comments on commit 96a9830

Please sign in to comment.