Skip to content

Commit

Permalink
Fix versions and artifact names in runner poms
Browse files Browse the repository at this point in the history
  • Loading branch information
@kennknowles
kennknowles committed Mar 15, 2016
1 parent a91e115 commit c168533
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion runners/flink/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

<parent>
<groupId>org.apache.beam</groupId>
<artifactId>runners-parent</artifactId>
<artifactId>runners</artifactId>
<version>1.6.0-SNAPSHOT</version>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion runners/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
</parent>

<groupId>org.apache.beam</groupId>
<artifactId>runners-parent</artifactId>
<artifactId>runners</artifactId>
<version>1.6.0-SNAPSHOT</version>

<packaging>pom</packaging>
Expand Down
4 changes: 2 additions & 2 deletions runners/spark/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ License.
<parent>
<groupId>org.apache.beam</groupId>
<artifactId>runners</artifactId>
<version>1.5.0-SNAPSHOT</version>
<version>1.6.0-SNAPSHOT</version>
</parent>

<artifactId>spark-runner</artifactId>
Expand All @@ -41,7 +41,7 @@ License.
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>1.7</java.version>
<spark.version>1.5.2</spark.version>
<beam.version>1.5.0-SNAPSHOT</beam.version>
<beam.version>1.6.0-SNAPSHOT</beam.version>
</properties>

<repositories>
Expand Down

3 comments on commit c168533

@mxm
Copy link
Contributor

@mxm mxm commented on c168533 Mar 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennknowles Do you think we can change the root pom artifactid of the runners to runners-parent? The issue is that users might use the runners artifact and think it includes all the runners when in fact it is just a pom file with no actual code. This is similar to the Beam root pom.

@davorbonaci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea. @kennknowles?

@kennknowles
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. Commented +1 on BEAM-116. It is not ideal that we have to have an artifactId at all or have the spurious parent-child relationship, but I don't know of an alternative. Definitely best to have a name that minimizes confusion.

Please sign in to comment.