Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: proto2_coder_test_messages_pb2.py is not generated via gen_protos.py #22319

Open
lukecwik opened this issue Jul 18, 2022 · 3 comments
Open

[Bug]: proto2_coder_test_messages_pb2.py is not generated via gen_protos.py #22319

lukecwik opened this issue Jul 18, 2022 · 3 comments
Assignees
@tvalentyn
Labels
bug core P2 python

Comments

@lukecwik
Copy link
Member

lukecwik commented Jul 18, 2022 •
edited
Loading

What happened?

It looks like proto2_coder_test_messages_pb2.py was generated once a long time ago and is not being maintained automatically by gen_protos.py or any other part of the build system.

Issue Priority

Priority: 3

Issue Component

Component: sdk-py-core
@lukecwik lukecwik self-assigned this Jul 18, 2022
@lukecwik lukecwik assigned tvalentyn and unassigned lukecwik Jul 18, 2022
@lukecwik
Copy link
Member Author

lukecwik commented Jul 18, 2022 •
edited
Loading

CC: @anandolee

lukecwik added a commit to lukecwik/incubator-beam that referenced this issue Jul 18, 2022
@lukecwik
[apache#22319] Regenerate proto2_coder_test_messages_pb2.py manually
3836841
lukecwik added a commit that referenced this issue Jul 19, 2022
@lukecwik
[#22319] Regenerate proto2_coder_test_messages_pb2.py manually (#22320)
f2be806 
* [#22319] Regenerate proto2_coder_test_messages_pb2.py manually

* Update instructions to regenerate proto file

* Fix pylint issue
@github-actions github-actions bot added the stale label Sep 17, 2022
@tvalentyn tvalentyn removed the stale label Oct 20, 2022
@AnandInguva
Copy link
Contributor

should we make this generate via gen_protos.py?

@tvalentyn
Copy link
Contributor

yes

@AnandInguva AnandInguva mentioned this issue Feb 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvalentyn tvalentyn

Labels
bug core P2 python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tvalentyn @lukecwik @AnandInguva