-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Add integration test for JmsIO #25887
Milestone
Comments
3 tasks
3 tasks
Abacn
pushed a commit
that referenced
this issue
Apr 5, 2023
* [#25887] fix(JmsIO): issue with multiple connection open #25887 - Issue related to multiple connection being open for each bundle - Add integration test using jms-qpid for JmsIO Fixes #25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [#25887] fix(JmsIO): create new CommonJms instance instead of extending it #25887 Fixes #25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [#25887] fix(JmsIO): replacing flag with producer null verification #25887 Fixes #25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [#25887] fix(JmsIO): replace google timestamp with java instant #25887 Fixes #25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> --------- Co-authored-by: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com>
jakubrauch
pushed a commit
to jakubrauch/beam
that referenced
this issue
Apr 27, 2023
…#25887 (apache#25945) * [apache#25887] fix(JmsIO): issue with multiple connection open apache#25887 - Issue related to multiple connection being open for each bundle - Add integration test using jms-qpid for JmsIO Fixes apache#25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [apache#25887] fix(JmsIO): create new CommonJms instance instead of extending it apache#25887 Fixes apache#25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [apache#25887] fix(JmsIO): replacing flag with producer null verification apache#25887 Fixes apache#25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [apache#25887] fix(JmsIO): replace google timestamp with java instant apache#25887 Fixes apache#25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> --------- Co-authored-by: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com>
rezarokni
pushed a commit
to rezarokni/beam
that referenced
this issue
May 22, 2023
…#25887 (apache#25945) * [apache#25887] fix(JmsIO): issue with multiple connection open apache#25887 - Issue related to multiple connection being open for each bundle - Add integration test using jms-qpid for JmsIO Fixes apache#25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [apache#25887] fix(JmsIO): create new CommonJms instance instead of extending it apache#25887 Fixes apache#25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [apache#25887] fix(JmsIO): replacing flag with producer null verification apache#25887 Fixes apache#25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> * [apache#25887] fix(JmsIO): replace google timestamp with java instant apache#25887 Fixes apache#25887 Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com> --------- Co-authored-by: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What needs to happen?
The unit test uses a built-in ActiveMQ and it does not catch the bug e.g. #25849. We need integration test that can be used to valid with different Jms softwares, like what we are doing for the JdbcIO (unit test uses a built-in Derby, integration tests run on both MySQL and PostSQL)
Issue Priority
Priority: 3 (nice-to-have improvement)
Issue Components
The text was updated successfully, but these errors were encountered: