Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Failing Test]: JmsIO tests flaky due to port occupied #26203

Open
2 of 15 tasks
Abacn opened this issue Apr 10, 2023 · 1 comment
Open
2 of 15 tasks

[Failing Test]: JmsIO tests flaky due to port occupied #26203

Abacn opened this issue Apr 10, 2023 · 1 comment
Labels
awaiting triage bug failing test flake io java jms P2 tests

Comments

@Abacn
Copy link
Contributor

Abacn commented Apr 10, 2023

What happened?

These tests use hard coded port 5672 for Jms connection:

beam/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOTest.java

Line 126 in 08f87c6

"vm://localhost", 5672, "jms.sendAcksAsync=false", ActiveMQConnectionFactory.class

If one Jenkins worker happens to run two JmsIO test suite at the same time, the later one will fail, e.g. https://ci-beam.apache.org/job/beam_PreCommit_Java_Jms_IO_Direct_Commit/563/

java.io.IOException: Failed to bind to server socket: amqp://localhost:5672?transport.transformer=jms due to: java.net.BindException: Address already in use (Bind failed)

Issue Failure

Failure: Test is flaky

Issue Priority

Priority: 2 (backlog / disabled test but we think the product is healthy)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Abacn
Copy link
Contributor Author

Abacn commented Apr 10, 2023

Introduced in #25945

Amraneze added a commit to Amraneze/beam that referenced this issue Jun 30, 2023
@Amraneze @amranezeRenault
[apache#27312] fix(JmsIO): create a session pool for JmsIO apache#27312
2500096 
[apache#26203] fix(JmsIO): use a unused port for tests in JmsIO apache#26203
Fixes apache#27312, apache#26203

Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com>
Amraneze added a commit to Amraneze/beam that referenced this issue Jun 30, 2023
@Amraneze @amranezeRenault
[apache#27312] fix(JmsIO): create a session pool for JmsIO apache#27312
55cb703 
[apache#26203] fix(JmsIO): use a unused port for tests in JmsIO apache#26203
Fixes apache#27312, apache#26203

Co-Authored-By: Amrane Ait Zeouay <122456352+amranezeRenault@users.noreply.github.com>
@Amraneze Amraneze mentioned this issue Jun 30, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting triage bug failing test flake io java jms P2 tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Abacn