Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task][prism] Have python wrapper check and download released prism binary if available. #31403

Closed
Tracked by #28187
lostluck opened this issue May 24, 2024 · 0 comments · Fixed by #31583
Closed
Tracked by #28187
Assignees

Comments

@lostluck
Copy link
Contributor

lostluck commented May 24, 2024

The binary zips we're putting up in GitHub release artifacts will be at URLs with the following pattern.

http://github.com/apache/beam/releases/download/RELEASE/apache_beam-RELEASE-prism-OS-ARCH.zip

This issue is the sibling to #31402.

This is with the full release version that matches the release tag. That is for version 2.57.0, the tag is v2.57.0.

Since we're building with Go os and architecture tags, we may need to translate however we detect those to match the Go build terms.

OS: windows linux darwin
ARCH: amd64 arm64

darwin is the Mac/OSX version.


Python seems to have a built in platform package where system returns a largely compatible version of the OS string (after to lowercase), and machine returns what seems to match the architecture.

This born out by another simple package (osarch), which uses these fairly simply under the hood., but doesn't return exactly what we need to fill in the download strings, so we may as well go with raw use of platform.


https://docs.python.org/3/library/zipfile.html is how zip files are handled in Python.


https://docs.python.org/3/library/urllib.request.html appears to be how to handle URL requests.

@lostluck lostluck changed the title Have python wrapper check and download released prism binary if available. [Task][prism] Have python wrapper check and download released prism binary if available. May 24, 2024
@lostluck lostluck self-assigned this Jun 12, 2024
lostluck added a commit to lostluck/beam that referenced this issue Jun 18, 2024
lostluck added a commit that referenced this issue Jun 20, 2024
#31644)

Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
lostluck added a commit to lostluck/beam that referenced this issue Jun 27, 2024
@github-actions github-actions bot added this to the 2.58.0 Release milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant