-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spark mapstate #31669
Add spark mapstate #31669
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
retest this please |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Thanks for the contribution. Could you please update the comments of the test class here beam/runners/spark/src/test/java/org/apache/beam/runners/spark/stateful/SparkStateInternalsTest.java Line 27 in 54a1538
now it no longer ignores map tests |
bb00c39
to
5ddcd17
Compare
I hadn't seen that comment, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, just have a minor comment
when pushing changes, please do not force push and just push a new commit instead, so reviewer can track diff
@@ -386,10 +386,16 @@ public void testMap() throws Exception { | |||
value.entries().readLater().read(), | |||
containsInAnyOrder(MapEntry.of("B", 2), MapEntry.of("D", 4), MapEntry.of("E", 5))); | |||
|
|||
// isEmpty | |||
assertThat(value.isEmpty().read(), equalTo(false)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use assertFalse / assertTrue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check!
Got it! I'll make sure to push new commits from now on, instead of force-pushing. Thanks so much! |
* add isEmpty test in testMap * add map state in spark runner * update comment on SparkStateInternalsTest * modify isEmpty test to assertFalse / assertTrue
Please add a meaningful description for your change here
fixes #31668
This PR contains theses change
isEmpty
test inStateInternalsTest#testMap
SparkRunner
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.