Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spark mapstate #31669

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Add spark mapstate #31669

merged 4 commits into from
Jun 28, 2024

Conversation

twosom
Copy link
Contributor

@twosom twosom commented Jun 22, 2024

Please add a meaningful description for your change here

fixes #31668

This PR contains theses change

  • add isEmpty test in StateInternalsTest#testMap
  • add map state in SparkRunner

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@twosom
Copy link
Contributor Author

twosom commented Jun 22, 2024

retest this please

@chamikaramj
Copy link
Contributor

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Jun 26, 2024

Thanks for the contribution. Could you please update the comments of the test class here

* Tests for {@link SparkStateInternals}. This is based on {@link StateInternalsTest}. Ignore set

now it no longer ignores map tests

@twosom
Copy link
Contributor Author

twosom commented Jun 27, 2024

Thanks for the contribution. Could you please update the comments of the test class here

* Tests for {@link SparkStateInternals}. This is based on {@link StateInternalsTest}. Ignore set

now it no longer ignores map tests

I hadn't seen that comment, thanks!

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just have a minor comment

when pushing changes, please do not force push and just push a new commit instead, so reviewer can track diff

@@ -386,10 +386,16 @@ public void testMap() throws Exception {
value.entries().readLater().read(),
containsInAnyOrder(MapEntry.of("B", 2), MapEntry.of("D", 4), MapEntry.of("E", 5)));

// isEmpty
assertThat(value.isEmpty().read(), equalTo(false));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use assertFalse / assertTrue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check!

@twosom
Copy link
Contributor Author

twosom commented Jun 28, 2024

thanks, just have a minor comment

when pushing changes, please do not force push and just push a new commit instead, so reviewer can track diff

Got it! I'll make sure to push new commits from now on, instead of force-pushing. Thanks so much!

@Abacn Abacn merged commit 3588d19 into apache:master Jun 28, 2024
19 of 21 checks passed
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
* add isEmpty test in testMap

* add map state in spark runner

* update comment on SparkStateInternalsTest

* modify isEmpty test to assertFalse / assertTrue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add MapState in SparkRunner
3 participants