Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Support StringSet Metrics in Beam for Dataflow #31788

Open
4 of 16 tasks
rohitsinha54 opened this issue Jul 5, 2024 · 1 comment
Open
4 of 16 tasks

[Feature Request]: Support StringSet Metrics in Beam for Dataflow #31788

rohitsinha54 opened this issue Jul 5, 2024 · 1 comment
Assignees
@rohitsinha54
Labels
dataflow go java new feature P2 python

Comments

@rohitsinha54
Copy link
Contributor

What would you like to happen?

Add support for String set metric in Beam which can track unique strings as metric.

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@rohitsinha54
Copy link
Contributor Author

.take-issue

@rohitsinha54 rohitsinha54 mentioned this issue Jul 6, 2024
Merged
3 tasks
robertwb added a commit that referenced this issue Jul 8, 2024
@rohitsinha54 @robertwb
Add support for StringSet metric in Java SDK. (#31789)
de4645d 
Add support for StringSet metric in Java SDK to track set of unique string as metric.
addresses #31788

* Add support for StringSet metric in Java SDK to track set of unique string as metric.

* Fix compilation and tests

* Add support for StringSet in PortableRunner and fix some spotless java checks

* Add support for StringSet in JetRunner

* Fix precommit errors

* Fixes for review comments

* Other fixes

* Fixes for spotless java

* Fix a couple of tests.

* Null-containing sets don't need to be tested as they can no longer be constructed.
* Use vendered guava.

* unused imports

---------

Co-authored-by: Robert Bradshaw <robertwb@gmail.com>
acrites pushed a commit to acrites/beam that referenced this issue Jul 17, 2024
@rohitsinha54 @robertwb @acrites
Add support for StringSet metric in Java SDK. (apache#31789)
e5cd98a 
Add support for StringSet metric in Java SDK to track set of unique string as metric.
addresses apache#31788

* Add support for StringSet metric in Java SDK to track set of unique string as metric.

* Fix compilation and tests

* Add support for StringSet in PortableRunner and fix some spotless java checks

* Add support for StringSet in JetRunner

* Fix precommit errors

* Fixes for review comments

* Other fixes

* Fixes for spotless java

* Fix a couple of tests.

* Null-containing sets don't need to be tested as they can no longer be constructed.
* Use vendered guava.

* unused imports

---------

Co-authored-by: Robert Bradshaw <robertwb@gmail.com>
@rohitsinha54 rohitsinha54 mentioned this issue Sep 27, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohitsinha54 rohitsinha54

Labels
dataflow go java new feature P2 python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohitsinha54